[GitHub] [iceberg] rdblue commented on a diff in pull request #5024: Core: bump Hadoop version to 3.2.0

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #5024:
URL: https://github.com/apache/iceberg/pull/5024#discussion_r896336657


##########
aliyun/src/test/java/org/apache/iceberg/aliyun/oss/mock/AliyunOSSMockLocalStore.java:
##########
@@ -37,8 +37,8 @@
 import java.util.List;
 import java.util.Locale;
 import java.util.Map;
+import org.apache.commons.codec.binary.Hex;

Review Comment:
   We try not to rely on Apache Commons for anything to avoid a direct dependency, even in tests (though it looks like that was already violated). Is there an easy way to replace this? We should be able to replace `FileUtils` with a `readFully` method in `IOUtil`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org