You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/06/26 21:02:52 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #6771: Add array / array sqllogic tests for `array_contains`
alamb opened a new pull request, #6771:
URL: https://github.com/apache/arrow-datafusion/pull/6771
Draft as it builds on https://github.com/apache/arrow-datafusion/pull/6618
# Which issue does this PR close?
Related to https://github.com/apache/arrow-datafusion/issues/6709
# Rationale for this change
While reviewing https://github.com/apache/arrow-datafusion/pull/6618 I felt there was a gap in coverage:
# What changes are included in this PR?
tests for array functions on array functions
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #6771: Minor: Add array / array sqllogic tests for `array_contains`
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #6771:
URL: https://github.com/apache/arrow-datafusion/pull/6771#discussion_r1245646339
##########
datafusion/core/tests/sqllogictests/test_files/array.slt:
##########
@@ -358,6 +386,10 @@ select make_array(x, y) from foo2;
----
[1.0, 1]
+# array_contains
Review Comment:
in eb6e88f43
##########
datafusion/core/tests/sqllogictests/test_files/array.slt:
##########
@@ -393,3 +425,42 @@ query BB rowsort
select array_contains(make_array(true, true, true), make_array(false, false)), array_contains([false, false, false], [true, true]);
----
false false
+
+# array_contains array
+
+statement ok
Review Comment:
Done in eb6e88f43
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #6771: Minor: Add array / array sqllogic tests for `array_contains`
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #6771:
URL: https://github.com/apache/arrow-datafusion/pull/6771
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #6771: Add array / array sqllogic tests for `array_contains`
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #6771:
URL: https://github.com/apache/arrow-datafusion/pull/6771#issuecomment-1610030796
> Is there any idea to do something similar with math, string, time functions? 🤔
We should for sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] izveigor commented on a diff in pull request #6771: Minor: Add array / array sqllogic tests for `array_contains`
Posted by "izveigor (via GitHub)" <gi...@apache.org>.
izveigor commented on code in PR #6771:
URL: https://github.com/apache/arrow-datafusion/pull/6771#discussion_r1245459187
##########
datafusion/core/tests/sqllogictests/test_files/array.slt:
##########
@@ -358,6 +386,10 @@ select make_array(x, y) from foo2;
----
[1.0, 1]
+# array_contains
Review Comment:
`## array_contains`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] izveigor commented on a diff in pull request #6771: Minor: Add array / array sqllogic tests for `array_contains`
Posted by "izveigor (via GitHub)" <gi...@apache.org>.
izveigor commented on code in PR #6771:
URL: https://github.com/apache/arrow-datafusion/pull/6771#discussion_r1245438910
##########
datafusion/core/tests/sqllogictests/test_files/array.slt:
##########
@@ -393,3 +425,42 @@ query BB rowsort
select array_contains(make_array(true, true, true), make_array(false, false)), array_contains([false, false, false], [true, true]);
----
false false
+
+# array_contains array
+
+statement ok
Review Comment:
I think it would be better to test nested arrays even more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] izveigor commented on pull request #6771: Add array / array sqllogic tests for `array_contains`
Posted by "izveigor (via GitHub)" <gi...@apache.org>.
izveigor commented on PR #6771:
URL: https://github.com/apache/arrow-datafusion/pull/6771#issuecomment-1609437727
Is there any idea to do something similar with math, string, time functions? 🤔
Sources:
https://github.com/apache/arrow-datafusion/blob/main/datafusion/core/tests/sqllogictests/test_files/math.slt
https://github.com/apache/arrow-datafusion/blob/main/datafusion/core/tests/sqllogictests/test_files/scalar.slt
https://github.com/apache/arrow-datafusion/blob/main/datafusion/core/tests/sqllogictests/test_files/strings.slt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org