[GitHub] [griffin] guoyuepeng commented on a change in pull request #526: [GRIFFIN-283] Move sink steps into TransformStep

[GitBox <gi...@apache.org>]

guoyuepeng commented on a change in pull request #526: [GRIFFIN-283] Move sink steps into TransformStep
URL: https://github.com/apache/griffin/pull/526#discussion_r316921504
 
 

 ##########
 File path: measure/src/main/scala/org/apache/griffin/measure/step/builder/dsl/transform/Expr2DQSteps.scala
 ##########
 @@ -32,6 +33,10 @@ trait Expr2DQSteps extends Loggable with Serializable {
 
   def getDQSteps(): Seq[DQStep]
 
+  implicit def recoredWriteStepToList(writeStep: RecordWriteStep): List[WriteStep] = writeStep :: Nil
+
+  implicit def metricsWriteStepToList(writeStep: MetricWriteStep): List[WriteStep] = writeStep :: Nil
 
 Review comment:
   I also think implicitly convert WriteStep into List[WriteStep] is over-assumption. we should explicitly declare it when used. 
   @wankunde What is your opinion?
   If we have to change the interface, then we can change it to make dq chain more clear.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services