You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by renslinden <gi...@git.apache.org> on 2017/04/10 09:12:27 UTC
[GitHub] cxf pull request #256: Add attributes in serialize functions
GitHub user renslinden opened a pull request:
https://github.com/apache/cxf/pull/256
Add attributes in serialize functions
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/renslinden/cxf master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cxf/pull/256.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #256
----
commit 7a8ce55055219023c7e132d0bbed37302d2b8324
Author: Rens van der Linden <re...@gmail.com>
Date: 2017-04-10T08:56:11Z
Add attributes in serialize functions
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf issue #256: Attributes support in serialize/deserialize functions [wsdl2...
Posted by dkulp <gi...@git.apache.org>.
Github user dkulp commented on the issue:
https://github.com/apache/cxf/pull/256
Definitely concerned about the set->add change. That will certainly break peoples code. Can the original method be retained with the add method being added?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf issue #256: Attributes support in serialize/deserialize functions [wsdl2...
Posted by coheigea <gi...@git.apache.org>.
Github user coheigea commented on the issue:
https://github.com/apache/cxf/pull/256
The unit tests have been modified, but I'd prefer to see a unit test added that (for example) failed with the old code but passes with the new code. Does changing from "add" to "set" for arrays break the API by the way?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf issue #256: Add attributes in serialize functions
Posted by renslinden <gi...@git.apache.org>.
Github user renslinden commented on the issue:
https://github.com/apache/cxf/pull/256
Jenkins says: "Build timed out (after 90 minutes). Marking the build as aborted."
What to do now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf issue #256: Attributes support in serialize/deserialize functions [wsdl2...
Posted by renslinden <gi...@git.apache.org>.
Github user renslinden commented on the issue:
https://github.com/apache/cxf/pull/256
@coheigea As you can see I have modified the unit tests in my last commit, so they runs well again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf issue #256: Attributes support in serialize/deserialize functions [wsdl2...
Posted by coheigea <gi...@git.apache.org>.
Github user coheigea commented on the issue:
https://github.com/apache/cxf/pull/256
Don't worry about the build timing out. Any chance of modifying/adding some tests for these new features?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---