[jira] Closed: (SLING-675) JspFactoryImpl class uses PageContext pooling but does not clear the ThreadLocals

["Felix Meschberger (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SLING-675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger closed SLING-675.
-----------------------------------

    Resolution: Fixed

Implemented pooling prevention in Rev. 698978/698980.

The problem with preventing pooling is, that the JspFactoryImpl class uses a system property to define whether to use pooling or not. When running in an container framework (OSGi, Servlet Container, App Server), using system properties is kind of problematic.

So we temporaly set the system property, load the JspFactoryImpl class to configure from the system property, and reset or clear the system property afterwards.

> JspFactoryImpl class uses PageContext pooling but does not clear the ThreadLocals
> ---------------------------------------------------------------------------------
>
>                 Key: SLING-675
>                 URL: https://issues.apache.org/jira/browse/SLING-675
>             Project: Sling
>          Issue Type: Bug
>          Components: Scripting JSP
>    Affects Versions: Scripting JSP 2.0.2
>            Reporter: Felix Meschberger
>            Assignee: Felix Meschberger
>             Fix For: Scripting JSP 2.0.4
>
>
> The JspFactoryImpl class uses pooling for the PageContext objects and stores the pools in ThreadLocals. Besides not being needed anymore these days, the problem with these thread locals is, that they are not cleaned up.
> So we have to take precaution to prevent using pools for the PageContext objects.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.