[GitHub] [arrow] save-buffer commented on pull request #13332: ARROW-16713: [C++] Pull join accumulation outside of HashJoinImpl

[GitBox <gi...@apache.org>]

save-buffer commented on PR #13332:
URL: https://github.com/apache/arrow/pull/13332#issuecomment-1149124849

   1. That's true. I did think it would be cleaner to have batches that are being operated on be owned by the data structure that's doing the work. For `ProbeBatches` specifically I could make a special "probing accumulation queue" that gets moved into instead. 
   2. Good point, will remove
   3. I initially did have it be thread-safe, but then I realized that most of them would have locks managed externally anyway: for spilling we'll be using PartitionLocks and for HashJoinNode we use the mutexes to protect stuff other than the AccumulationQueues, so in neither case will we actually ever use the AccumulationQueue's mutex. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org