You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2020/03/24 04:11:42 UTC
[Impala-ASF-CR] IMPALA-9547: retry accept in test shell commandline
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15541
Change subject: IMPALA-9547: retry accept in test_shell_commandline
......................................................................
IMPALA-9547: retry accept in test_shell_commandline
This is a point solution to this particular socket.accept()
call failing. The more general problem is described in
https://www.python.org/dev/peps/pep-0475/ and fixed in
Python 3.5.
Change-Id: Icc9cab98b059042855ca9149427d079951471be0
---
M tests/shell/test_shell_commandline.py
1 file changed, 10 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/15541/1
--
To view, visit http://gerrit.cloudera.org:8080/15541
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icc9cab98b059042855ca9149427d079951471be0
Gerrit-Change-Number: 15541
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-9547: retry accept in test shell commandline
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15541 )
Change subject: IMPALA-9547: retry accept in test_shell_commandline
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5539/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/15541
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc9cab98b059042855ca9149427d079951471be0
Gerrit-Change-Number: 15541
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Mar 2020 15:30:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9547: retry accept in test shell commandline
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Abhishek Rawat, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15541
to look at the new patch set (#2).
Change subject: IMPALA-9547: retry accept in test_shell_commandline
......................................................................
IMPALA-9547: retry accept in test_shell_commandline
This is a point solution to this particular socket.accept()
call failing. The more general problem is described in
https://www.python.org/dev/peps/pep-0475/ and fixed in
Python 3.5.
Change-Id: Icc9cab98b059042855ca9149427d079951471be0
---
M tests/shell/test_shell_commandline.py
1 file changed, 10 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/15541/2
--
To view, visit http://gerrit.cloudera.org:8080/15541
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icc9cab98b059042855ca9149427d079951471be0
Gerrit-Change-Number: 15541
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-9547: retry accept in test shell commandline
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15541 )
Change subject: IMPALA-9547: retry accept in test_shell_commandline
......................................................................
IMPALA-9547: retry accept in test_shell_commandline
This is a point solution to this particular socket.accept()
call failing. The more general problem is described in
https://www.python.org/dev/peps/pep-0475/ and fixed in
Python 3.5.
Change-Id: Icc9cab98b059042855ca9149427d079951471be0
Reviewed-on: http://gerrit.cloudera.org:8080/15541
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/shell/test_shell_commandline.py
1 file changed, 10 insertions(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/15541
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Icc9cab98b059042855ca9149427d079951471be0
Gerrit-Change-Number: 15541
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-9547: retry accept in test shell commandline
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15541 )
Change subject: IMPALA-9547: retry accept in test_shell_commandline
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5584/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15541
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc9cab98b059042855ca9149427d079951471be0
Gerrit-Change-Number: 15541
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Mar 2020 06:37:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9547: retry accept in test shell commandline
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15541 )
Change subject: IMPALA-9547: retry accept in test_shell_commandline
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/15541
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc9cab98b059042855ca9149427d079951471be0
Gerrit-Change-Number: 15541
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Mar 2020 20:31:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9547: retry accept in test shell commandline
Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/15541 )
Change subject: IMPALA-9547: retry accept in test_shell_commandline
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/15541
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc9cab98b059042855ca9149427d079951471be0
Gerrit-Change-Number: 15541
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Mar 2020 14:20:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9547: retry accept in test shell commandline
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15541 )
Change subject: IMPALA-9547: retry accept in test_shell_commandline
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15541
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc9cab98b059042855ca9149427d079951471be0
Gerrit-Change-Number: 15541
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Mar 2020 15:29:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9547: retry accept in test shell commandline
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15541 )
Change subject: IMPALA-9547: retry accept in test_shell_commandline
......................................................................
Patch Set 1:
(23 comments)
http://gerrit.cloudera.org:8080/#/c/15541/1/tests/shell/test_shell_commandline.py
File tests/shell/test_shell_commandline.py:
http://gerrit.cloudera.org:8080/#/c/15541/1/tests/shell/test_shell_commandline.py@793
PS1, Line 793: # IMPALA-9547: retry accept(). This is required in Python < 3.5 because some
flake8: E101 indentation contains mixed spaces and tabs
http://gerrit.cloudera.org:8080/#/c/15541/1/tests/shell/test_shell_commandline.py@793
PS1, Line 793: # IMPALA-9547: retry accept(). This is required in Python < 3.5 because some
flake8: W191 indentation contains tabs
http://gerrit.cloudera.org:8080/#/c/15541/1/tests/shell/test_shell_commandline.py@793
PS1, Line 793: # IMPALA-9547: retry accept(). This is required in Python < 3.5 because some
tab used for whitespace
http://gerrit.cloudera.org:8080/#/c/15541/1/tests/shell/test_shell_commandline.py@794
PS1, Line 794: # EINTR return calls from syscalls are not automatically retried. See PEP475.
flake8: W191 indentation contains tabs
http://gerrit.cloudera.org:8080/#/c/15541/1/tests/shell/test_shell_commandline.py@794
PS1, Line 794: # EINTR return calls from syscalls are not automatically retried. See PEP475.
tab used for whitespace
http://gerrit.cloudera.org:8080/#/c/15541/1/tests/shell/test_shell_commandline.py@795
PS1, Line 795: while True:
flake8: W191 indentation contains tabs
http://gerrit.cloudera.org:8080/#/c/15541/1/tests/shell/test_shell_commandline.py@795
PS1, Line 795: while True:
tab used for whitespace
http://gerrit.cloudera.org:8080/#/c/15541/1/tests/shell/test_shell_commandline.py@796
PS1, Line 796: try:
flake8: W191 indentation contains tabs
http://gerrit.cloudera.org:8080/#/c/15541/1/tests/shell/test_shell_commandline.py@796
PS1, Line 796:
flake8: E101 indentation contains mixed spaces and tabs
http://gerrit.cloudera.org:8080/#/c/15541/1/tests/shell/test_shell_commandline.py@796
PS1, Line 796: try:
tab used for whitespace
http://gerrit.cloudera.org:8080/#/c/15541/1/tests/shell/test_shell_commandline.py@797
PS1, Line 797: connection, client_address = sock.accept()
flake8: W191 indentation contains tabs
http://gerrit.cloudera.org:8080/#/c/15541/1/tests/shell/test_shell_commandline.py@797
PS1, Line 797:
flake8: E101 indentation contains mixed spaces and tabs
http://gerrit.cloudera.org:8080/#/c/15541/1/tests/shell/test_shell_commandline.py@797
PS1, Line 797: connection, client_address = sock.accept()
tab used for whitespace
http://gerrit.cloudera.org:8080/#/c/15541/1/tests/shell/test_shell_commandline.py@798
PS1, Line 798: break
flake8: E101 indentation contains mixed spaces and tabs
http://gerrit.cloudera.org:8080/#/c/15541/1/tests/shell/test_shell_commandline.py@799
PS1, Line 799: except IOError, e:
flake8: E101 indentation contains mixed spaces and tabs
http://gerrit.cloudera.org:8080/#/c/15541/1/tests/shell/test_shell_commandline.py@799
PS1, Line 799: except IOError, e:
flake8: W191 indentation contains tabs
http://gerrit.cloudera.org:8080/#/c/15541/1/tests/shell/test_shell_commandline.py@799
PS1, Line 799: except IOError, e:
tab used for whitespace
http://gerrit.cloudera.org:8080/#/c/15541/1/tests/shell/test_shell_commandline.py@800
PS1, Line 800: if e.errno != errno.EINTR:
flake8: W191 indentation contains tabs
http://gerrit.cloudera.org:8080/#/c/15541/1/tests/shell/test_shell_commandline.py@800
PS1, Line 800:
flake8: E101 indentation contains mixed spaces and tabs
http://gerrit.cloudera.org:8080/#/c/15541/1/tests/shell/test_shell_commandline.py@800
PS1, Line 800: if e.errno != errno.EINTR:
tab used for whitespace
http://gerrit.cloudera.org:8080/#/c/15541/1/tests/shell/test_shell_commandline.py@801
PS1, Line 801: raise
flake8: W191 indentation contains tabs
http://gerrit.cloudera.org:8080/#/c/15541/1/tests/shell/test_shell_commandline.py@801
PS1, Line 801:
flake8: E101 indentation contains mixed spaces and tabs
http://gerrit.cloudera.org:8080/#/c/15541/1/tests/shell/test_shell_commandline.py@801
PS1, Line 801: raise
tab used for whitespace
--
To view, visit http://gerrit.cloudera.org:8080/15541
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc9cab98b059042855ca9149427d079951471be0
Gerrit-Change-Number: 15541
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Mar 2020 04:12:32 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9547: retry accept in test shell commandline
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15541 )
Change subject: IMPALA-9547: retry accept in test_shell_commandline
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15541
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc9cab98b059042855ca9149427d079951471be0
Gerrit-Change-Number: 15541
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Mar 2020 15:30:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9547: retry accept in test shell commandline
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15541 )
Change subject: IMPALA-9547: retry accept in test_shell_commandline
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5583/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15541
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc9cab98b059042855ca9149427d079951471be0
Gerrit-Change-Number: 15541
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Mar 2020 04:52:39 +0000
Gerrit-HasComments: No