You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pdfbox.apache.org by Tilman Hausherr <TH...@t-online.de> on 2018/03/20 16:23:11 UTC
Re: svn commit: r1827316 -
/pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/ttf/GlyphSubstitutionTable.java
Am 20.03.2018 um 15:45 schrieb msahyoun@apache.org:
> - gid = doLookup(lookupTable, gid);
> + lookupResult = doLookup(lookupTable, gid);
I think that this changes the meaning. Because now gid is the original
parameter, before the change gid was the current variable due to
overwriting.
Tilman
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org
Re: svn commit: r1827316 -
/pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/ttf/GlyphSubstitutionTable.java
Posted by Maruan Sahyoun <sa...@fileaffairs.de>.
thanks for the review - commited in r1827338 - simply forgot to replace the parameter with the new one :-(
> Am 20.03.2018 um 17:46 schrieb Andreas Lehmkuehler <an...@lehmi.de>:
>
> On 03/20/2018 05:23 PM, Tilman Hausherr wrote:
>> Am 20.03.2018 um 15:45 schrieb msahyoun@apache.org:
>>> - gid = doLookup(lookupTable, gid);
>>> + lookupResult = doLookup(lookupTable, gid);
>> I think that this changes the meaning. Because now gid is the original parameter, before the change gid was the current variable due to overwriting.
> I guess all occurences of gid have to be replaced, like the following:
>
> lookupResult = doLookup(lookupTable, lookupResult);
>
>
> Andreas
>> Tilman
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
>> For additional commands, e-mail: dev-help@pdfbox.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
> For additional commands, e-mail: dev-help@pdfbox.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org
Re: svn commit: r1827316 -
/pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/ttf/GlyphSubstitutionTable.java
Posted by Andreas Lehmkuehler <an...@lehmi.de>.
On 03/20/2018 05:23 PM, Tilman Hausherr wrote:
> Am 20.03.2018 um 15:45 schrieb msahyoun@apache.org:
>> - gid = doLookup(lookupTable, gid);
>> + lookupResult = doLookup(lookupTable, gid);
>
>
> I think that this changes the meaning. Because now gid is the original
> parameter, before the change gid was the current variable due to overwriting.
I guess all occurences of gid have to be replaced, like the following:
lookupResult = doLookup(lookupTable, lookupResult);
Andreas
>
> Tilman
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
> For additional commands, e-mail: dev-help@pdfbox.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org