You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/18 10:54:11 UTC
[GitHub] [airflow] feluelle opened a new pull request #7757: [AIRFLOW-4679]
Make airflow/operators Pylint compatible
feluelle opened a new pull request #7757: [AIRFLOW-4679] Make airflow/operators Pylint compatible
URL: https://github.com/apache/airflow/pull/7757
- remove unused lineage_data field in BashOperator
- fix string formatting in AirflowException in PythonVirtualenvOperator
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7757:
[AIRFLOW-4679] Make airflow/operators Pylint compatible
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7757: [AIRFLOW-4679] Make airflow/operators Pylint compatible
URL: https://github.com/apache/airflow/pull/7757#issuecomment-600572990
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7757?src=pr&el=h1) Report
> Merging [#7757](https://codecov.io/gh/apache/airflow/pull/7757?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/4e626be3c90d76fac7ffc3a6b5c6fed10753fd38?src=pr&el=desc) will **decrease** coverage by `0.07%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7757?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7757 +/- ##
==========================================
- Coverage 86.98% 86.91% -0.08%
==========================================
Files 915 915
Lines 44231 44224 -7
==========================================
- Hits 38476 38436 -40
- Misses 5755 5788 +33
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7757?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/operators/python.py](https://codecov.io/gh/apache/airflow/pull/7757/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcHl0aG9uLnB5) | `94.96% <100%> (-0.04%)` | :arrow_down: |
| [airflow/operators/check\_operator.py](https://codecov.io/gh/apache/airflow/pull/7757/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvY2hlY2tfb3BlcmF0b3IucHk=) | `92.48% <100%> (-0.12%)` | :arrow_down: |
| [airflow/operators/bash.py](https://codecov.io/gh/apache/airflow/pull/7757/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvYmFzaC5weQ==) | `90.38% <100%> (-0.19%)` | :arrow_down: |
| [airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/7757/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5) | `50% <0%> (-50%)` | :arrow_down: |
| [...roviders/google/cloud/operators/postgres\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7757/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9wb3N0Z3Jlc190b19nY3MucHk=) | `54.28% <0%> (-31.43%)` | :arrow_down: |
| [airflow/providers/postgres/hooks/postgres.py](https://codecov.io/gh/apache/airflow/pull/7757/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvaG9va3MvcG9zdGdyZXMucHk=) | `78.87% <0%> (-15.5%)` | :arrow_down: |
| [...ogle/cloud/example\_dags/example\_cloud\_sql\_query.py](https://codecov.io/gh/apache/airflow/pull/7757/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX2Nsb3VkX3NxbF9xdWVyeS5weQ==) | `98.33% <0%> (ø)` | :arrow_up: |
| [...viders/google/cloud/example\_dags/example\_vision.py](https://codecov.io/gh/apache/airflow/pull/7757/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX3Zpc2lvbi5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [...ers/google/cloud/example\_dags/example\_datastore.py](https://codecov.io/gh/apache/airflow/pull/7757/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX2RhdGFzdG9yZS5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [...s/google/cloud/example\_dags/example\_cloud\_build.py](https://codecov.io/gh/apache/airflow/pull/7757/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX2Nsb3VkX2J1aWxkLnB5) | `100% <0%> (ø)` | :arrow_up: |
| ... and [10 more](https://codecov.io/gh/apache/airflow/pull/7757/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7757?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7757?src=pr&el=footer). Last update [4e626be...a6c55ec](https://codecov.io/gh/apache/airflow/pull/7757?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil merged pull request #7757: [AIRFLOW-4679] Make
airflow/operators Pylint compatible
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #7757: [AIRFLOW-4679] Make airflow/operators Pylint compatible
URL: https://github.com/apache/airflow/pull/7757
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] feluelle commented on a change in pull request #7757:
[AIRFLOW-4679] Make airflow/operators Pylint compatible
Posted by GitBox <gi...@apache.org>.
feluelle commented on a change in pull request #7757: [AIRFLOW-4679] Make airflow/operators Pylint compatible
URL: https://github.com/apache/airflow/pull/7757#discussion_r394942342
##########
File path: airflow/operators/python.py
##########
@@ -278,8 +284,8 @@ def __init__(
if (not isinstance(self.python_callable,
types.FunctionType) or (self.python_callable.__name__ ==
(lambda x: 0).__name__)):
- raise AirflowException('{} only supports functions for python_callable arg',
- self.__class__.__name__)
+ raise AirflowException('{} only supports functions for python_callable arg'.format(
+ self.__class__.__name__))
Review comment:
Sure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] feluelle commented on a change in pull request #7757:
[AIRFLOW-4679] Make airflow/operators Pylint compatible
Posted by GitBox <gi...@apache.org>.
feluelle commented on a change in pull request #7757: [AIRFLOW-4679] Make airflow/operators Pylint compatible
URL: https://github.com/apache/airflow/pull/7757#discussion_r394942133
##########
File path: airflow/operators/bash.py
##########
@@ -100,8 +100,6 @@ def execute(self, context):
for k, v in airflow_context_vars.items()]))
env.update(airflow_context_vars)
- self.lineage_data = self.bash_command
Review comment:
@ashb @mik-laj do you know if this is required?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on a change in pull request #7757:
[AIRFLOW-4679] Make airflow/operators Pylint compatible
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #7757: [AIRFLOW-4679] Make airflow/operators Pylint compatible
URL: https://github.com/apache/airflow/pull/7757#discussion_r395203937
##########
File path: airflow/operators/bash.py
##########
@@ -100,8 +100,6 @@ def execute(self, context):
for k, v in airflow_context_vars.items()]))
env.update(airflow_context_vars)
- self.lineage_data = self.bash_command
Review comment:
Yes it is required
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on a change in pull request #7757:
[AIRFLOW-4679] Make airflow/operators Pylint compatible
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #7757: [AIRFLOW-4679] Make airflow/operators Pylint compatible
URL: https://github.com/apache/airflow/pull/7757#discussion_r395203937
##########
File path: airflow/operators/bash.py
##########
@@ -100,8 +100,6 @@ def execute(self, context):
for k, v in airflow_context_vars.items()]))
env.update(airflow_context_vars)
- self.lineage_data = self.bash_command
Review comment:
Yes it is required
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] nuclearpinguin commented on a change in pull request
#7757: [AIRFLOW-4679] Make airflow/operators Pylint compatible
Posted by GitBox <gi...@apache.org>.
nuclearpinguin commented on a change in pull request #7757: [AIRFLOW-4679] Make airflow/operators Pylint compatible
URL: https://github.com/apache/airflow/pull/7757#discussion_r394270974
##########
File path: airflow/operators/python.py
##########
@@ -278,8 +284,8 @@ def __init__(
if (not isinstance(self.python_callable,
types.FunctionType) or (self.python_callable.__name__ ==
(lambda x: 0).__name__)):
- raise AirflowException('{} only supports functions for python_callable arg',
- self.__class__.__name__)
+ raise AirflowException('{} only supports functions for python_callable arg'.format(
+ self.__class__.__name__))
Review comment:
Should we use f-string?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] nuclearpinguin commented on a change in pull request
#7757: [AIRFLOW-4679] Make airflow/operators Pylint compatible
Posted by GitBox <gi...@apache.org>.
nuclearpinguin commented on a change in pull request #7757: [AIRFLOW-4679] Make airflow/operators Pylint compatible
URL: https://github.com/apache/airflow/pull/7757#discussion_r394271404
##########
File path: airflow/operators/bash.py
##########
@@ -100,8 +100,6 @@ def execute(self, context):
for k, v in airflow_context_vars.items()]))
env.update(airflow_context_vars)
- self.lineage_data = self.bash_command
Review comment:
Isn't it something related to lineage? 👀
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7757:
[AIRFLOW-4679] Make airflow/operators Pylint compatible
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7757: [AIRFLOW-4679] Make airflow/operators Pylint compatible
URL: https://github.com/apache/airflow/pull/7757#issuecomment-600572990
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7757?src=pr&el=h1) Report
> Merging [#7757](https://codecov.io/gh/apache/airflow/pull/7757?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/4e626be3c90d76fac7ffc3a6b5c6fed10753fd38&el=desc) will **decrease** coverage by `0.07%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/airflow/pull/7757?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7757 +/- ##
==========================================
- Coverage 86.98% 86.91% -0.08%
==========================================
Files 915 915
Lines 44231 44224 -7
==========================================
- Hits 38476 38436 -40
- Misses 5755 5788 +33
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7757?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/operators/bash.py](https://codecov.io/gh/apache/airflow/pull/7757/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvYmFzaC5weQ==) | `90.38% <100.00%> (-0.19%)` | :arrow_down: |
| [airflow/operators/check\_operator.py](https://codecov.io/gh/apache/airflow/pull/7757/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvY2hlY2tfb3BlcmF0b3IucHk=) | `92.48% <100.00%> (-0.12%)` | :arrow_down: |
| [airflow/operators/python.py](https://codecov.io/gh/apache/airflow/pull/7757/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcHl0aG9uLnB5) | `94.96% <100.00%> (-0.04%)` | :arrow_down: |
| [airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/7757/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...roviders/google/cloud/operators/postgres\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7757/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9wb3N0Z3Jlc190b19nY3MucHk=) | `54.28% <0.00%> (-31.43%)` | :arrow_down: |
| [airflow/providers/postgres/hooks/postgres.py](https://codecov.io/gh/apache/airflow/pull/7757/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvaG9va3MvcG9zdGdyZXMucHk=) | `78.87% <0.00%> (-15.50%)` | :arrow_down: |
| [...providers/google/cloud/example\_dags/example\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7757/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX2djcy5weQ==) | `96.29% <0.00%> (ø)` | |
| [...viders/google/cloud/example\_dags/example\_speech.py](https://codecov.io/gh/apache/airflow/pull/7757/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX3NwZWVjaC5weQ==) | `100.00% <0.00%> (ø)` | |
| [...viders/google/cloud/example\_dags/example\_vision.py](https://codecov.io/gh/apache/airflow/pull/7757/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX3Zpc2lvbi5weQ==) | `100.00% <0.00%> (ø)` | |
| [...iders/google/cloud/example\_dags/example\_compute.py](https://codecov.io/gh/apache/airflow/pull/7757/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX2NvbXB1dGUucHk=) | `100.00% <0.00%> (ø)` | |
| ... and [10 more](https://codecov.io/gh/apache/airflow/pull/7757/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7757?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7757?src=pr&el=footer). Last update [4e626be...a6c55ec](https://codecov.io/gh/apache/airflow/pull/7757?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7757: [AIRFLOW-4679] Make
airflow/operators Pylint compatible
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7757: [AIRFLOW-4679] Make airflow/operators Pylint compatible
URL: https://github.com/apache/airflow/pull/7757#issuecomment-600572990
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7757?src=pr&el=h1) Report
> Merging [#7757](https://codecov.io/gh/apache/airflow/pull/7757?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/4e626be3c90d76fac7ffc3a6b5c6fed10753fd38&el=desc) will **decrease** coverage by `0.07%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/airflow/pull/7757?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7757 +/- ##
==========================================
- Coverage 86.98% 86.91% -0.08%
==========================================
Files 915 915
Lines 44231 44224 -7
==========================================
- Hits 38476 38436 -40
- Misses 5755 5788 +33
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7757?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/operators/bash.py](https://codecov.io/gh/apache/airflow/pull/7757/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvYmFzaC5weQ==) | `90.38% <100.00%> (-0.19%)` | :arrow_down: |
| [airflow/operators/check\_operator.py](https://codecov.io/gh/apache/airflow/pull/7757/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvY2hlY2tfb3BlcmF0b3IucHk=) | `92.48% <100.00%> (-0.12%)` | :arrow_down: |
| [airflow/operators/python.py](https://codecov.io/gh/apache/airflow/pull/7757/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcHl0aG9uLnB5) | `94.96% <100.00%> (-0.04%)` | :arrow_down: |
| [airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/7757/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...roviders/google/cloud/operators/postgres\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7757/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9wb3N0Z3Jlc190b19nY3MucHk=) | `54.28% <0.00%> (-31.43%)` | :arrow_down: |
| [airflow/providers/postgres/hooks/postgres.py](https://codecov.io/gh/apache/airflow/pull/7757/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvaG9va3MvcG9zdGdyZXMucHk=) | `78.87% <0.00%> (-15.50%)` | :arrow_down: |
| [...providers/google/cloud/example\_dags/example\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7757/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX2djcy5weQ==) | `96.29% <0.00%> (ø)` | |
| [...viders/google/cloud/example\_dags/example\_speech.py](https://codecov.io/gh/apache/airflow/pull/7757/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX3NwZWVjaC5weQ==) | `100.00% <0.00%> (ø)` | |
| [...viders/google/cloud/example\_dags/example\_vision.py](https://codecov.io/gh/apache/airflow/pull/7757/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX3Zpc2lvbi5weQ==) | `100.00% <0.00%> (ø)` | |
| [...iders/google/cloud/example\_dags/example\_compute.py](https://codecov.io/gh/apache/airflow/pull/7757/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX2NvbXB1dGUucHk=) | `100.00% <0.00%> (ø)` | |
| ... and [10 more](https://codecov.io/gh/apache/airflow/pull/7757/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7757?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7757?src=pr&el=footer). Last update [4e626be...a6c55ec](https://codecov.io/gh/apache/airflow/pull/7757?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on a change in pull request #7757:
[AIRFLOW-4679] Make airflow/operators Pylint compatible
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #7757: [AIRFLOW-4679] Make airflow/operators Pylint compatible
URL: https://github.com/apache/airflow/pull/7757#discussion_r395204888
##########
File path: airflow/operators/bash.py
##########
@@ -100,8 +100,6 @@ def execute(self, context):
for k, v in airflow_context_vars.items()]))
env.update(airflow_context_vars)
- self.lineage_data = self.bash_command
Review comment:
No, it is no longer required. The lineage backend has been modified and this was used earlier
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7757:
[AIRFLOW-4679] Make airflow/operators Pylint compatible
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7757: [AIRFLOW-4679] Make airflow/operators Pylint compatible
URL: https://github.com/apache/airflow/pull/7757#issuecomment-600572990
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7757?src=pr&el=h1) Report
> Merging [#7757](https://codecov.io/gh/apache/airflow/pull/7757?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/4e626be3c90d76fac7ffc3a6b5c6fed10753fd38&el=desc) will **decrease** coverage by `0.07%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/airflow/pull/7757?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7757 +/- ##
==========================================
- Coverage 86.98% 86.91% -0.08%
==========================================
Files 915 915
Lines 44231 44224 -7
==========================================
- Hits 38476 38436 -40
- Misses 5755 5788 +33
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7757?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/operators/bash.py](https://codecov.io/gh/apache/airflow/pull/7757/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvYmFzaC5weQ==) | `90.38% <100.00%> (-0.19%)` | :arrow_down: |
| [airflow/operators/check\_operator.py](https://codecov.io/gh/apache/airflow/pull/7757/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvY2hlY2tfb3BlcmF0b3IucHk=) | `92.48% <100.00%> (-0.12%)` | :arrow_down: |
| [airflow/operators/python.py](https://codecov.io/gh/apache/airflow/pull/7757/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcHl0aG9uLnB5) | `94.96% <100.00%> (-0.04%)` | :arrow_down: |
| [airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/7757/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...roviders/google/cloud/operators/postgres\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7757/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9wb3N0Z3Jlc190b19nY3MucHk=) | `54.28% <0.00%> (-31.43%)` | :arrow_down: |
| [airflow/providers/postgres/hooks/postgres.py](https://codecov.io/gh/apache/airflow/pull/7757/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvaG9va3MvcG9zdGdyZXMucHk=) | `78.87% <0.00%> (-15.50%)` | :arrow_down: |
| [...providers/google/cloud/example\_dags/example\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7757/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX2djcy5weQ==) | `96.29% <0.00%> (ø)` | |
| [...viders/google/cloud/example\_dags/example\_speech.py](https://codecov.io/gh/apache/airflow/pull/7757/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX3NwZWVjaC5weQ==) | `100.00% <0.00%> (ø)` | |
| [...viders/google/cloud/example\_dags/example\_vision.py](https://codecov.io/gh/apache/airflow/pull/7757/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX3Zpc2lvbi5weQ==) | `100.00% <0.00%> (ø)` | |
| [...iders/google/cloud/example\_dags/example\_compute.py](https://codecov.io/gh/apache/airflow/pull/7757/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX2NvbXB1dGUucHk=) | `100.00% <0.00%> (ø)` | |
| ... and [10 more](https://codecov.io/gh/apache/airflow/pull/7757/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7757?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7757?src=pr&el=footer). Last update [4e626be...a6c55ec](https://codecov.io/gh/apache/airflow/pull/7757?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services