[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #1130: refactor(java-client): optimize the code style of PegasusScanner

[GitBox <gi...@apache.org>]

acelyc111 commented on code in PR #1130:
URL: https://github.com/apache/incubator-pegasus/pull/1130#discussion_r952132525


##########
java-client/src/main/java/org/apache/pegasus/client/ClientOptions.java:
##########
@@ -233,7 +233,6 @@ public int hashCode() {
     result = 31 * result + Objects.hashCode(falconPushInterval.toMillis());
     result = 31 * result + (enableWriteLimit ? 1 : 0);
     result = 31 * result + Objects.hashCode(metaQueryTimeout.toMillis());
-    result = 31 * result + authProtocol.hashCode();

Review Comment:
   @foreverneverer Rebase the master branch for every PR before merging into the master branch is too costly, and some unit tests are flacky, it will last a very long time.
   
   I agree to @totalo , we can add some regular CI on master branch for Java, Go, and etc, code, as how cpp code is doing now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org