You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/02/10 15:24:26 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #245: drivers/telnet: Stop the loop if SIGSTP char is match

xiaoxiang781216 commented on a change in pull request #245: drivers/telnet: Stop the loop if SIGSTP char is match
URL: https://github.com/apache/incubator-nuttx/pull/245#discussion_r377129959
 
 

 ##########
 File path: drivers/net/telnet.c
 ##########
 @@ -308,6 +308,7 @@ static void telnet_check_ctrlchar(FAR struct telnet_dev_s *priv,
         }
       else
 #endif
 
 Review comment:
   SIGINT has the high priority than SIGSTP, we can't break out  immediately if we find SIGSTP char because we may SIGINT char in the later. But if SIGINT isn't enabled, it is safe to break out.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services