You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/08/29 13:10:04 UTC

[GitHub] [shardingsphere] dongzl edited a comment on pull request #7111: Add with segment parser for SQLServer insert statement.

dongzl edited a comment on pull request #7111:
URL: https://github.com/apache/shardingsphere/pull/7111#issuecomment-683288182


   Hi @tristaZero @jingshanglu , I understand for all the database SQL dialects, they have the same parts and there also will be some differences, we should take the same parts to the parent class, and take the differences to subclass. But split them into different subclasses will need more time, I also suggest we can finish the SQL collation firstly and then consider splitting them.
   
   Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org