You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Christopher Schultz (Jira)" <ji...@apache.org> on 2019/09/28 12:42:00 UTC
[jira] [Comment Edited] (CODEC-239) Allows "look-alike" characters
like 0 (digit zero) and 1 (digit one) as aliases for O (uppercase oh) and I
(uppercase eye) respectively when decoding
[ https://issues.apache.org/jira/browse/CODEC-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16940007#comment-16940007 ]
Christopher Schultz edited comment on CODEC-239 at 9/28/19 12:41 PM:
---------------------------------------------------------------------
@Gary I draw the line precisely here.
Base32 has a well-defined alphabet, and only two characters have look-alikes. I'm not suggesting we support a radically different alphabet.
As for not correcting for human errors anywhere else, there is mod_speling and the commons-validator project is dedicated entirely to detecting human errors. The Base32 class already ignores stuff it doesn't already understand; witness both CODEC-134 and the fact that Base32 simply discards characters it doesn't understand. So there is a certain degree of slop that this class already accepts and probably should *not*.
was (Author: chris@christopherschultz.net):
@Gary I draw the line precisely here.
Base32 has a well-defined alphabet, and only two characters have look-alikes. I'm not suggesting we support a radically different alphabet.
As for not correcting for human errors anywhere else, there is mod_speling and the commons-validator project is dedicated entirely to detecting human errors. The Base32 class already ignores stuff it doesn't already understand; witness CODEC-134. So there is a certain degree of slop that this class already accepts and probably should *not*.
> Allows "look-alike" characters like 0 (digit zero) and 1 (digit one) as aliases for O (uppercase oh) and I (uppercase eye) respectively when decoding
> -----------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: CODEC-239
> URL: https://issues.apache.org/jira/browse/CODEC-239
> Project: Commons Codec
> Issue Type: Improvement
> Affects Versions: 1.10
> Reporter: Christopher Schultz
> Priority: Minor
> Labels: patch-available
> Attachments: CODEC-239-2.diff, CODEC-239.diff
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Allowing {{1}} -> {{I}} and {{0}} -> {{O}} can help usability, especially for human users who are entering data expected to be in base32-encoded format.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)