You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by andrewgaul <gi...@git.apache.org> on 2015/07/06 06:37:36 UTC
[GitHub] maven-plugins pull request: Suggest using verify phase for Checkst...
GitHub user andrewgaul opened a pull request:
https://github.com/apache/maven-plugins/pull/56
Suggest using verify phase for Checkstyle
The Maven lifecycle[1] reference suggests using validate to:
> validate the project is correct and all necessary information is available.
and verify to:
> run any checks to verify the package is valid and meets quality criteria.
The latter better matches Checkstyle's functionality and matches
similar tools like FindBugs[2].
[1] https://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.html#Lifecycle_Reference
[2] http://gleclaire.github.io/findbugs-maven-plugin/check-mojo.html
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andrewgaul/maven-plugins checkstyle-verify
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven-plugins/pull/56.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #56
----
commit e4e3f5f60db859be5d93bd3edc27e32622c4096d
Author: Andrew Gaul <an...@gaul.org>
Date: 2015-07-06T04:32:15Z
Suggest using verify phase for Checkstyle
The Maven lifecycle[1] reference suggests using validate to:
validate the project is correct and all necessary information is
available.
and verify to:
run any checks to verify the package is valid and meets quality
criteria.
The latter better matches Checkstyle's functionality and matches
similar tools like FindBugs[2].
[1] https://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.html#Lifecycle_Reference
[2] http://gleclaire.github.io/findbugs-maven-plugin/check-mojo.html
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-plugins pull request: Suggest using verify phase for Checkst...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/maven-plugins/pull/56
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org