You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by kevinjmh <gi...@git.apache.org> on 2018/09/04 02:36:36 UTC
[GitHub] carbondata pull request #2688: [CARBONDATA-2911] Remove unused BTree related...
GitHub user kevinjmh opened a pull request:
https://github.com/apache/carbondata/pull/2688
[CARBONDATA-2911] Remove unused BTree related code
1. BTree related code is only used by a test class called`BTreeBlockFinderTest`.
2. BTreeDataRefNodeFinder in AbstractDetailQueryResultIterator never run. All dataRefNode are actually instanceof BlockletDataRefNode
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kevinjmh/carbondata remove_btree_related
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2688.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2688
----
commit 47f18af7277acaec8de4e166d6a268b2fa8b2e7e
Author: Manhua <ke...@...>
Date: 2018-09-04T02:20:07Z
remove btree related code
----
---
[GitHub] carbondata issue #2688: [CARBONDATA-2911] Remove unused BTree related code
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2688
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/205/
---
[GitHub] carbondata pull request #2688: [CARBONDATA-2911] Remove unused BTree related...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2688
---
[GitHub] carbondata issue #2688: [CARBONDATA-2911] Remove unused BTree related code
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/2688
LGTM
---
[GitHub] carbondata issue #2688: [CARBONDATA-2911] Remove unused BTree related code
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2688
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/8276/
---
[GitHub] carbondata issue #2688: [CARBONDATA-2911] Remove unused BTree related code
Posted by xuchuanyin <gi...@git.apache.org>.
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2688
@jackylk I have doubt about the below scenario:
For sort_columns, the minmax is ordered for all the blocks/blocklets in one segment.
Suppose that we are doing filtering on sort_columns and the filter looks like Col1='bb'.
If the minmax values for blocklet#1, blocklet#2, blocklet#3 is [a,c), [c,d), [d,e).
After carbondata find max value of blocklet#1 already covers filter value 'bb', Will it **still compare** filter value 'bb' with the minmax of the rest blocklets#2/#3?
I though the BTree can be used to avoid these comparison. Am I wrong?
---