You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "snuyanzin (via GitHub)" <gi...@apache.org> on 2023/12/02 23:22:06 UTC
[PR] [FLINK-33727][table] Use different sink names for restore tests [flink]
snuyanzin opened a new pull request, #23858:
URL: https://github.com/apache/flink/pull/23858
## What is the purpose of the change
In restore tests there is `MySink` name for sinks and it seems to be the problem for restore tests. For more details see jira.
The PR just renames these sinks for every table program
## Verifying this change
The issue was 100% reproduced by executing all tests for `RestoreTestBase`
In same way it could be tested
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): ( no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: ( no)
- The serializers: (no )
- The runtime per-record code paths (performance sensitive): (no )
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no )
- The S3 file system connector: (no )
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33727][table] Use different sink names for restore tests [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #23858:
URL: https://github.com/apache/flink/pull/23858#issuecomment-1837922338
closing since finally the change introduced such ci failures was at https://github.com/apache/flink/pull/23861
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33727][table] Use different sink names for restore tests [flink]
Posted by "JingGe (via GitHub)" <gi...@apache.org>.
JingGe commented on code in PR #23858:
URL: https://github.com/apache/flink/pull/23858#discussion_r1413009264
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/JoinTestPrograms.java:
##########
@@ -142,7 +142,7 @@ public class JoinTestPrograms {
.setupTableSource(SOURCE_T1)
.setupTableSource(SOURCE_T2)
.setupTableSink(
- SinkTestStep.newBuilder("MySink")
+ SinkTestStep.newBuilder("NON_WINDOW_INNER_JOIN_WITH_NULL_Sink")
Review Comment:
It is a great idea to use data warehouse like naming convention to improve the readability. It would be even better to follow the naming convention that table names commonly use lower case letters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33727][table] Use different sink names for restore tests [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #23858:
URL: https://github.com/apache/flink/pull/23858#discussion_r1413116026
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/JoinTestPrograms.java:
##########
@@ -142,7 +142,7 @@ public class JoinTestPrograms {
.setupTableSource(SOURCE_T1)
.setupTableSource(SOURCE_T2)
.setupTableSink(
- SinkTestStep.newBuilder("MySink")
+ SinkTestStep.newBuilder("NON_WINDOW_INNER_JOIN_WITH_NULL_Sink")
Review Comment:
makes sense, thanks
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33727][table] Use different sink names for restore tests [flink]
Posted by "jnh5y (via GitHub)" <gi...@apache.org>.
jnh5y commented on PR #23858:
URL: https://github.com/apache/flink/pull/23858#issuecomment-1837506076
> Are there any savepoint where currently changed names were participating?
Yes.
> Then how to find all? Or is it just a question in general?
The savepoints are living under directories in https://github.com/apache/flink/tree/master/flink-table/flink-table-planner/src/test/resources/restore-tests, e.g. https://github.com/apache/flink/tree/master/flink-table/flink-table-planner/src/test/resources/restore-tests/stream-exec-join_1/anti-join/savepoint
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33727][table] Use different sink names for restore tests [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #23858:
URL: https://github.com/apache/flink/pull/23858#issuecomment-1837503632
Are there any savepoint where currently changed names were participating? Then how to find all?
Or is it just a question in general?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33727][table] Use different sink names for restore tests [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #23858:
URL: https://github.com/apache/flink/pull/23858#issuecomment-1837279346
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "da62de304dcaeef07bda7d8da7bfc082737b14fa",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da62de304dcaeef07bda7d8da7bfc082737b14fa",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da62de304dcaeef07bda7d8da7bfc082737b14fa UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33727][table] Use different sink names for restore tests [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin closed pull request #23858: [FLINK-33727][table] Use different sink names for restore tests
URL: https://github.com/apache/flink/pull/23858
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org