You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "Fokko (via GitHub)" <gi...@apache.org> on 2023/06/10 07:05:30 UTC
[GitHub] [spark] Fokko opened a new pull request, #41542: [SPARK-43594][SQL] Add LocalDateTime to anyToMicros
Fokko opened a new pull request, #41542:
URL: https://github.com/apache/spark/pull/41542
### What changes were proposed in this pull request?
Small change to `anyToMicros` to also accept `LocalDateTime` that's being returned when working with `TIMESTAMP_NTZ`. This simplifies some code at the Iceberg side.
### Why are the changes needed?
With the introduction of the TIMESTAMP_NTZ it is convient to also accept LocalDateTime
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Very trivial change, no test needed.
Closes #41238 from Fokko/fd-add-local-date-time.
Authored-by: Fokko Driesprong <fo...@tabular.io>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Fokko commented on pull request #41542: [SPARK-43594][SQL] Add LocalDateTime to anyToMicros
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #41542:
URL: https://github.com/apache/spark/pull/41542#issuecomment-1585527698
cc @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #41542: [SPARK-43594][SQL] Add LocalDateTime to anyToMicros
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #41542: [SPARK-43594][SQL] Add LocalDateTime to anyToMicros
URL: https://github.com/apache/spark/pull/41542
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #41542: [SPARK-43594][SQL] Add LocalDateTime to anyToMicros
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #41542:
URL: https://github.com/apache/spark/pull/41542#issuecomment-1585538829
Sorry but it seems to be I was unclear.
Apache Spark community has a backporting policy to allow only bug fixes. SPARK-43594 is reported as `Improvement`.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org