You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@bahir.apache.org by GitBox <gi...@apache.org> on 2021/01/11 08:49:16 UTC
[GitHub] [bahir-flink] eskabetxe commented on a change in pull request #104: [BAHIR-247] Provide connection validation/idle testing for Flink-Redis Connector
eskabetxe commented on a change in pull request #104:
URL: https://github.com/apache/bahir-flink/pull/104#discussion_r554891072
##########
File path: flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/container/RedisCommandsContainerBuilder.java
##########
@@ -66,10 +66,20 @@ public static RedisCommandsContainer build(FlinkJedisPoolConfig jedisPoolConfig)
genericObjectPoolConfig.setMaxIdle(jedisPoolConfig.getMaxIdle());
genericObjectPoolConfig.setMaxTotal(jedisPoolConfig.getMaxTotal());
genericObjectPoolConfig.setMinIdle(jedisPoolConfig.getMinIdle());
+ genericObjectPoolConfig.setTestOnBorrow(jedisPoolConfig.getTestOnBorrow());
+ genericObjectPoolConfig.setTestOnReturn(jedisPoolConfig.getTestOnReturn());
+
+ if (jedisPoolConfig.getTestWhileIdle()) {
+ // default parameters from redis.clients.jedis.JedisPoolConfig
+ genericObjectPoolConfig.setTestWhileIdle(true);
Review comment:
if this are the default params, why we have to set them?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org