You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by minifirocks <gi...@git.apache.org> on 2018/04/23 16:12:16 UTC
[GitHub] nifi-minifi-cpp pull request #306: MINIFICPP-457: Network Management Control...
GitHub user minifirocks opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/306
MINIFICPP-457: Network Management Controller Service for interface bi…
…nding
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/minifirocks/nifi-minifi-cpp network_controller_interface_bind
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/306.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #306
----
commit ec65487e2ab6936c49c6822b9a3966e66e756379
Author: Bin Qiu <be...@...>
Date: 2018-04-23T15:39:30Z
MINIFICPP-457: Network Management Controller Service for interface binding
----
---
[GitHub] nifi-minifi-cpp issue #306: MINIFICPP-457: Network Management Controller Ser...
Posted by minifirocks <gi...@git.apache.org>.
Github user minifirocks commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/306
@achristianson add test case
---
[GitHub] nifi-minifi-cpp issue #306: MINIFICPP-457: Network Management Controller Ser...
Posted by achristianson <gi...@git.apache.org>.
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/306
Is there a way to add a unit/integration test for this?
---
[GitHub] nifi-minifi-cpp pull request #306: MINIFICPP-457: Network Management Control...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/306
---
[GitHub] nifi-minifi-cpp issue #306: MINIFICPP-457: Network Management Controller Ser...
Posted by minifirocks <gi...@git.apache.org>.
Github user minifirocks commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/306
@achristianson please review
---