You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sis.apache.org by GitBox <gi...@apache.org> on 2021/05/11 11:27:16 UTC

[GitHub] [sis-site] kinow opened a new pull request #1: Use Hugo to generate static site

kinow opened a new pull request #1:
URL: https://github.com/apache/sis-site/pull/1


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [sis-site] kinow commented on a change in pull request #1: Use Hugo to generate static site

Posted by GitBox <gi...@apache.org>.
kinow commented on a change in pull request #1:
URL: https://github.com/apache/sis-site/pull/1#discussion_r630081248



##########
File path: DOAP.rdf
##########
@@ -51,7 +51,7 @@
         <asfext:title>GeoAPI</asfext:title>
         <asfext:body>Open Geospatial Consortium</asfext:body>
         <asfext:id>OGC 09-083r3</asfext:id>
-        <asfext:url rdf:resource = "https://www.ogc.org/standards/geoapi"/>
+        <asfext:url rdf:resource = "http://www.opengeospatial.org/standards/geoapi"/>

Review comment:
       I don't recall why this value changed. Maybe I got the wrong file, or it changed after I did the porting to Hugo @desruisseaux ?

##########
File path: README.md
##########
@@ -0,0 +1,47 @@
+<!--
+   Licensed to the Apache Software Foundation (ASF) under one or more
+   contributor license agreements.  See the NOTICE file distributed with
+   this work for additional information regarding copyright ownership.
+   The ASF licenses this file to You under the Apache License, Version 2.0
+   (the "License"); you may not use this file except in compliance with
+   the License.  You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing, software
+   distributed under the License is distributed on an "AS IS" BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+   See the License for the specific language governing permissions and
+   limitations under the License.
+-->
+# Apache SIS website
+
+This is the source code for the website of [Apache SIS](https://sis.apache.org/), hosted at:
+
+    https://sis.apache.org/
+
+## Repository structure
+
+This repository uses 2 branches for building the website.
+- The `master` branch, which contains all the sources for the website.

Review comment:
       Will send a commit to replace by `main`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [sis-site] asfgit merged pull request #1: Use Hugo to generate static site

Posted by GitBox <gi...@apache.org>.
asfgit merged pull request #1:
URL: https://github.com/apache/sis-site/pull/1


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [sis-site] desruisseaux commented on a change in pull request #1: Use Hugo to generate static site

Posted by GitBox <gi...@apache.org>.
desruisseaux commented on a change in pull request #1:
URL: https://github.com/apache/sis-site/pull/1#discussion_r630109944



##########
File path: DOAP.rdf
##########
@@ -51,7 +51,7 @@
         <asfext:title>GeoAPI</asfext:title>
         <asfext:body>Open Geospatial Consortium</asfext:body>
         <asfext:id>OGC 09-083r3</asfext:id>
-        <asfext:url rdf:resource = "https://www.ogc.org/standards/geoapi"/>
+        <asfext:url rdf:resource = "http://www.opengeospatial.org/standards/geoapi"/>

Review comment:
       I do not know neither. "https://www.ogc.org/standards/geoapi" seems the right URL. The most likely is that it changed after the port to Hugo I think.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [sis-site] desruisseaux commented on a change in pull request #1: Use Hugo to generate static site

Posted by GitBox <gi...@apache.org>.
desruisseaux commented on a change in pull request #1:
URL: https://github.com/apache/sis-site/pull/1#discussion_r630124835



##########
File path: static/release-notes/0.7.html
##########
@@ -14,7 +14,7 @@ <h1>SIS 0.7 Release notes</h1>
 <h2>Summary</h2>
 <p>The main new features of Apache SIS 0.7 are:</p>
 <ul>
-  <li>Creation of Coordinate Reference System (CRS) objects from an <a href="https://epsg.org/">EPSG</a> code.
+  <li>Creation of Coordinate Reference System (CRS) objects from an <a href="http://www.epsg.org/">EPSG</a> code.

Review comment:
       This is another change that may have been done after port to Hugo site. We should keep the "https://epsg.org/" URL.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [sis-site] desruisseaux commented on a change in pull request #1: Use Hugo to generate static site

Posted by GitBox <gi...@apache.org>.
desruisseaux commented on a change in pull request #1:
URL: https://github.com/apache/sis-site/pull/1#discussion_r630126440



##########
File path: static/tables/CoordinateOperationMethods.html
##########
@@ -23,8 +23,8 @@ <h1>Apache SIS™ Coordinate Operation Methods</h1>
           The <code>semi-major</code> and <code>semi-minor</code> parameters are needed for all map projections,
           but usually do not need to be specified explicitly since they are inferred from the ellipsoid
           (unless <a href="http://sis.apache.org/apidocs/org/apache/sis/referencing/operation/transform/DefaultMathTransformFactory.html">creating parameterized transforms directly</a>).
-          For this reason, those parameters are usually not shown in <a href="https://epsg.org/">EPSG registry</a>
-          or <a href="https://docs.ogc.org/is/12-063r5/12-063r5.html">Well Known Text</a> (WKT) definitions.
+          For this reason, those parameters are usually not shown in <a href="http://www.epsg-registry.org">EPSG registry</a>
+          or <a href="http://docs.opengeospatial.org/is/12-063r5/12-063r5.html">Well Known Text</a> (WKT) definitions.

Review comment:
       More generally, maybe we should revert all changes in the `static/*.html` files… Since there is no reason for those files to change, all differences are probably edition added after the port to Hugo.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [sis-site] desruisseaux commented on a change in pull request #1: Use Hugo to generate static site

Posted by GitBox <gi...@apache.org>.
desruisseaux commented on a change in pull request #1:
URL: https://github.com/apache/sis-site/pull/1#discussion_r630128379



##########
File path: book/README.txt
##########
@@ -1,18 +0,0 @@
-This directory contains the source files for the developer guide in HTML5 format.

Review comment:
       Actually we need to keep all files in the `book` directory as well. They are the source files used for generating the big HTML file in the `static` directory. Do we have a place where to put source HTML files? Not static files, but source files consumed by some tools (e.g. for adding a Table of Content) for generating the final HTML file.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [sis-site] kinow commented on pull request #1: Use Hugo to generate static site

Posted by GitBox <gi...@apache.org>.
kinow commented on pull request #1:
URL: https://github.com/apache/sis-site/pull/1#issuecomment-838314709


   Hi @desruisseaux take a look at my comments, and see if there's anything I forgot to include, or that changed since I ported the content over to Hugo, please. If you point in a review what's missing or wrong I can update it tomorrow.
   
   Also, the book is now in the static directory. Start the server as in the `README.md`, and visit `localhost:1313`. That should give you the complete site to navigate locally, including Javadocs, book, etc.
   
   Thanks!
   Bruno


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org