You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2022/04/01 14:16:12 UTC
[GitHub] [cassandra] adelapena commented on a change in pull request #1546: CASSANDRA-17150 trunk: Guardrails for disk usage
adelapena commented on a change in pull request #1546:
URL: https://github.com/apache/cassandra/pull/1546#discussion_r840630044
##########
File path: src/java/org/apache/cassandra/db/guardrails/Guardrail.java
##########
@@ -75,6 +85,9 @@ protected void warn(String message)
protected void warn(String message, String redactedMessage)
{
+ if (skipNotifying(true))
Review comment:
I'm a bit on the fence about omitting the client warning when `minNotifyIntervalInMs` is set. We want that property to not overflow server logs nor emit millions of diagnostic events when there are replicas with stuffed disks. But it might be legit to still send the warning to the client, although on the other hand we could also overflow client's logs if we emit client warnings for every write done when a node is stuffed.
##########
File path: src/java/org/apache/cassandra/db/guardrails/Guardrail.java
##########
@@ -75,6 +85,9 @@ protected void warn(String message)
protected void warn(String message, String redactedMessage)
{
+ if (skipNotifying(true))
Review comment:
I'm a bit on the fence about omitting the client warning when `minNotifyIntervalInMs` is set. We want that property to not overflow server logs nor emit millions of diagnostic events when there are replicas with stuffed disks. But it might be legit to still send the warning to the client, although on the other hand we could also overflow client's logs if we emit client warnings for every write done when a node is stuffed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org