[GitHub] [spark] gengliangwang commented on a diff in pull request #39093: [SPARK-41420][UI] Protobuf serializer for ApplicationInfoWrapper

[GitBox <gi...@apache.org>]

gengliangwang commented on code in PR #39093:
URL: https://github.com/apache/spark/pull/39093#discussion_r1051304099


##########
core/src/test/scala/org/apache/spark/status/protobuf/KVStoreProtobufSerializerSuite.scala:
##########
@@ -176,4 +176,59 @@ class KVStoreProtobufSerializerSuite extends SparkFunSuite {
     assert(result.stageId == input.stageId)
     assert(result.stageAttemptId == input.stageAttemptId)
   }
+
+  test("Application Info") {
+    val attempts: Seq[ApplicationAttemptInfo] = Seq(
+      ApplicationAttemptInfo(
+        attemptId = Some("001"),
+        startTime = new Date(1),
+        endTime = new Date(10),
+        lastUpdated = new Date(10),

Review Comment:
   Let's have different values in the test case to avoid mistakes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org