[GitHub] [cloudstack-primate] shwstppr commented on a change in pull request #413: Adding custom Vue to change the vm service offering

[GitBox <gi...@apache.org>]

shwstppr commented on a change in pull request #413:
URL: https://github.com/apache/cloudstack-primate/pull/413#discussion_r439314566



##########
File path: src/views/compute/ChangeServiceOffering.vue
##########
@@ -0,0 +1,209 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+<template>
+  <div>
+    <p v-html="$t('message.change.offering.confirm')"></p>
+
+    <a-form class="form">
+      <div v-if="loading" class="loading">
+        <a-icon type="loading" style="color: #1890ff;"></a-icon>
+      </div>
+
+      <div class="form__item">
+        <p class="form__label">
+          <span class="required">*</span>
+          {{ $t('label.menu.service.offerings') }}
+        </p>
+        <a-select v-model="selectedOffering" :defaultValue="selectedOffering">
+          <a-select-option
+            v-for="offering in offerings"
+            :key="offering.name"
+            :value="offering.id"
+          >{{ offering.name }}</a-select-option>
+        </a-select>
+      </div>
+
+      <template v-if="isOfferingCustomized()">
+        <div class="form__item">
+          <p class="form__label">
+            <span class="required">*</span>
+            {{ $t('label.cpuspeed') }}
+          </p>
+          <a-input-number v-model="cpuSpeed"></a-input-number>
+          <span v-if="validationError" class="required">{{ $t('label.required') }}</span>
+        </div>
+
+        <div class="form__item">
+          <p class="form__label">
+            <span class="required">*</span>
+            {{ $t('label.cpunumber') }}
+          </p>
+          <a-input-number v-model="cpuNumber"></a-input-number>
+          <span v-if="validationError" class="required">{{ $t('label.required') }}</span>
+        </div>
+
+        <div class="form__item">
+          <p class="form__label">
+            <span class="required">*</span>
+            {{ $t('label.memory.mb') }}

Review comment:
       ```suggestion
               {{ $t('label.memory') }}
   ```
   Or we add key for this in translation if not there already




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org