[GitHub] [apisix] spacewander commented on a change in pull request #4676: feat: support dash in args (#4519)

[GitBox <gi...@apache.org>]

spacewander commented on a change in pull request #4676:
URL: https://github.com/apache/apisix/pull/4676#discussion_r681370460



##########
File path: t/core/ctx2.t
##########
@@ -136,3 +136,69 @@ qr/balancer_ip: 127.0.0.1|balancer_port: 1980/
 --- grep_error_log_out
 balancer_ip: 127.0.0.1
 balancer_port: 1980
+
+
+
+=== TEST 5: support dash in the args
+--- config
+    location /t {
+        content_by_lua_block {
+            local core = require("apisix.core")
+            local ngx_ctx = ngx.ctx
+            local api_ctx = ngx_ctx.api_ctx
+            if api_ctx == nil then
+                api_ctx = core.tablepool.fetch("api_ctx", 0, 32)

Review comment:
       It is not a good idea to set up api_ctx directly. We should let APISIX set it. See https://github.com/apache/apisix/pull/4676#discussion_r680302823




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org