[GitHub] [maven-doxia] elharo commented on a change in pull request #8: [DOXIA-534] Migrate logging to slf4j and deprecate doxia-logging-api

[GitBox <gi...@apache.org>]

elharo commented on a change in pull request #8: [DOXIA-534] Migrate logging to slf4j and deprecate doxia-logging-api
URL: https://github.com/apache/maven-doxia/pull/8#discussion_r395993290
 
 

 ##########
 File path: doxia-core/src/main/java/org/apache/maven/doxia/parser/AbstractParser.java
 ##########
 @@ -151,6 +153,7 @@ public void executeMacro( String macroId, MacroRequest request, Sink sink )
      * @return The base directory.
      * @deprecated this does not work in multi-module builds, see DOXIA-373
      */
+    @Deprecated
     protected File getBasedir()
     {
         // TODO: This is baaad, it should come in with the request.
 
 Review comment:
   delete now irrelevant todo

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org