You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/12/03 12:55:42 UTC
[GitHub] [shardingsphere] Qianyi951015 opened a new pull request, #22629: Remove Create and Alter Sharding Auditor
Qianyi951015 opened a new pull request, #22629:
URL: https://github.com/apache/shardingsphere/pull/22629
Changes proposed in this pull request:
- Remove Create Sharding Auditor
- Remove Alter Sharding Auditor
-
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [x] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang merged pull request #22629: Remove Create and Alter Sharding Auditor
Posted by GitBox <gi...@apache.org>.
RaigorJiang merged PR #22629:
URL: https://github.com/apache/shardingsphere/pull/22629
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #22629: Remove Create and Alter Sharding Auditor
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #22629:
URL: https://github.com/apache/shardingsphere/pull/22629#issuecomment-1336160203
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/22629?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22629](https://codecov.io/gh/apache/shardingsphere/pull/22629?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c7175aa) into [master](https://codecov.io/gh/apache/shardingsphere/commit/36a943c2286f2f2908fb2ca39ab0a1b5c53cac8f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (36a943c) will **decrease** coverage by `0.05%`.
> The diff coverage is `57.14%`.
> :exclamation: Current head c7175aa differs from pull request most recent head c82c339. Consider uploading reports for the commit c82c339 to get more accurate results
```diff
@@ Coverage Diff @@
## master #22629 +/- ##
============================================
- Coverage 49.73% 49.68% -0.06%
+ Complexity 2445 2434 -11
============================================
Files 4114 4112 -2
Lines 57598 57512 -86
Branches 9836 9831 -5
============================================
- Hits 28648 28576 -72
+ Misses 26493 26481 -12
+ Partials 2457 2455 -2
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/22629?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...update/DropBroadcastTableRuleStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/22629/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhcmRpbmcvZGlzdHNxbC9oYW5kbGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9kaXN0c3FsL2hhbmRsZXIvdXBkYXRlL0Ryb3BCcm9hZGNhc3RUYWJsZVJ1bGVTdGF0ZW1lbnRVcGRhdGVyLmphdmE=) | `72.72% <0.00%> (-8.23%)` | :arrow_down: |
| [.../update/DropShardingTableRuleStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/22629/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhcmRpbmcvZGlzdHNxbC9oYW5kbGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9kaXN0c3FsL2hhbmRsZXIvdXBkYXRlL0Ryb3BTaGFyZGluZ1RhYmxlUnVsZVN0YXRlbWVudFVwZGF0ZXIuamF2YQ==) | `75.38% <0.00%> (-2.75%)` | :arrow_down: |
| [...l/parser/core/ShardingDistSQLStatementVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/22629/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhcmRpbmcvZGlzdHNxbC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL2Rpc3RzcWwvcGFyc2VyL2NvcmUvU2hhcmRpbmdEaXN0U1FMU3RhdGVtZW50VmlzaXRvci5qYXZh) | `0.00% <ø> (ø)` | |
| [...line/core/execute/ShardingSphereDataJobWorker.java](https://codecov.io/gh/apache/shardingsphere/pull/22629/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9jb3JlL2V4ZWN1dGUvU2hhcmRpbmdTcGhlcmVEYXRhSm9iV29ya2VyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...arser/sql/common/segment/dal/FromTableSegment.java](https://codecov.io/gh/apache/shardingsphere/pull/22629/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3FsLXBhcnNlci9zdGF0ZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvc3FsL2NvbW1vbi9zZWdtZW50L2RhbC9Gcm9tVGFibGVTZWdtZW50LmphdmE=) | `0.00% <ø> (ø)` | |
| [...rser/sql/common/segment/dal/ShowFilterSegment.java](https://codecov.io/gh/apache/shardingsphere/pull/22629/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3FsLXBhcnNlci9zdGF0ZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvc3FsL2NvbW1vbi9zZWdtZW50L2RhbC9TaG93RmlsdGVyU2VnbWVudC5qYXZh) | `0.00% <ø> (ø)` | |
| [.../sql/common/segment/dal/VariableAssignSegment.java](https://codecov.io/gh/apache/shardingsphere/pull/22629/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3FsLXBhcnNlci9zdGF0ZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvc3FsL2NvbW1vbi9zZWdtZW50L2RhbC9WYXJpYWJsZUFzc2lnblNlZ21lbnQuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...parser/sql/common/segment/dal/VariableSegment.java](https://codecov.io/gh/apache/shardingsphere/pull/22629/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3FsLXBhcnNlci9zdGF0ZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvc3FsL2NvbW1vbi9zZWdtZW50L2RhbC9WYXJpYWJsZVNlZ21lbnQuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...t/ddl/column/alter/AddColumnDefinitionSegment.java](https://codecov.io/gh/apache/shardingsphere/pull/22629/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3FsLXBhcnNlci9zdGF0ZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvc3FsL2NvbW1vbi9zZWdtZW50L2RkbC9jb2x1bW4vYWx0ZXIvQWRkQ29sdW1uRGVmaW5pdGlvblNlZ21lbnQuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...dl/column/alter/ChangeColumnDefinitionSegment.java](https://codecov.io/gh/apache/shardingsphere/pull/22629/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3FsLXBhcnNlci9zdGF0ZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvc3FsL2NvbW1vbi9zZWdtZW50L2RkbC9jb2x1bW4vYWx0ZXIvQ2hhbmdlQ29sdW1uRGVmaW5pdGlvblNlZ21lbnQuamF2YQ==) | `0.00% <ø> (ø)` | |
| ... and [55 more](https://codecov.io/gh/apache/shardingsphere/pull/22629/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org