You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@apr.apache.org by tr...@apache.org on 2001/02/25 02:24:37 UTC
cvs commit: apr/threadproc/unix thread.c
trawick 01/02/24 17:24:37
Modified: threadproc/unix thread.c
Log:
if we don't have the prototype, we shouldn't have the function either
(haven't we been here before?)
Revision Changes Path
1.36 +0 -83 apr/threadproc/unix/thread.c
Index: thread.c
===================================================================
RCS file: /home/cvs/apr/threadproc/unix/thread.c,v
retrieving revision 1.35
retrieving revision 1.36
diff -u -r1.35 -r1.36
--- thread.c 2001/02/16 04:16:19 1.35
+++ thread.c 2001/02/25 01:24:37 1.36
@@ -235,92 +235,9 @@
#if !APR_HAS_THREADS
-apr_status_t apr_thread_create(apr_thread_t **new_thread, apr_threadattr_t *attr,
- apr_thread_start_t func, void *data,
- apr_pool_t *cont)
-{
- return APR_ENOTIMPL;
-}
-
-apr_status_t apr_threadattr_create(apr_threadattr_t **new, apr_pool_t *cont)
-{
- return APR_ENOTIMPL;
-}
-
-apr_status_t apr_threadkey_private_create(apr_threadkey_t **key, void (*dest)(void *),
- apr_pool_t *cont)
-{
- return APR_ENOTIMPL;
-}
-
-apr_status_t apr_threadkey_private_delete(apr_threadkey_t *key)
-{
- return APR_ENOTIMPL;
-}
-
apr_status_t apr_os_thread_get(void); /* avoid warning for no prototype */
apr_status_t apr_os_thread_get(void)
-{
- return APR_ENOTIMPL;
-}
-
-apr_status_t apr_threadattr_detach_set(apr_threadattr_t *attr)
-{
- return APR_ENOTIMPL;
-}
-
-apr_status_t apr_thread_data_get(void **data, const char *key, apr_thread_t *thread)
-{
- return APR_ENOTIMPL;
-}
-
-apr_status_t apr_threadkey_data_get(void **data, const char *key,
- apr_threadkey_t *threadkey)
-{
- return APR_ENOTIMPL;
-}
-
-apr_status_t apr_threadkey_private_get(void **new_mem, apr_threadkey_t *key)
-{
- return APR_ENOTIMPL;
-}
-
-apr_status_t apr_threadattr_detach_get(apr_threadattr_t *attr, apr_int32_t on)
-{
- return APR_ENOTIMPL;
-}
-
-apr_status_t apr_thread_data_set(void *data, const char *key,
- apr_status_t (*cleanup)(void *),
- apr_thread_t *thread)
-{
- return APR_ENOTIMPL;
-}
-
-apr_status_t apr_threadkey_data_set(void *data, const char *key,
- apr_status_t (*cleanup) (void *),
- apr_threadkey_t *threadkey)
-{
- return APR_ENOTIMPL;
-}
-
-apr_status_t apr_threadkey_private_set(void *priv, apr_threadkey_t *key)
-{
- return APR_ENOTIMPL;
-}
-
-apr_status_t apr_thread_detach(apr_thread_t *thd)
-{
- return APR_ENOTIMPL;
-}
-
-apr_status_t apr_thread_exit(apr_thread_t *thd, apr_status_t *retval)
-{
- return APR_ENOTIMPL;
-}
-
-apr_status_t apr_thread_join(apr_status_t *retval, apr_thread_t *thd)
{
return APR_ENOTIMPL;
}
Re: cvs commit: apr/threadproc/unix thread.c
Posted by rb...@covalent.net.
On 25 Feb 2001 trawick@apache.org wrote:
> trawick 01/02/24 17:24:37
>
> Modified: threadproc/unix thread.c
> Log:
> if we don't have the prototype, we shouldn't have the function either
>
> (haven't we been here before?)
We've been here hundreds of times, and we are likely to reverse this
again. However, this code was horribly broken. We would try to build a
threaded MPM without threads in the server, and we would succeed just
fine. Then when we tried to run the code, it would fail miserably.
Removing the code is the correct solution.
Ryan
_______________________________________________________________________________
Ryan Bloom rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------
Re: cvs commit: apr/threadproc/unix thread.c
Posted by rb...@covalent.net.
On 25 Feb 2001 trawick@apache.org wrote:
> trawick 01/02/24 17:24:37
>
> Modified: threadproc/unix thread.c
> Log:
> if we don't have the prototype, we shouldn't have the function either
>
> (haven't we been here before?)
We've been here hundreds of times, and we are likely to reverse this
again. However, this code was horribly broken. We would try to build a
threaded MPM without threads in the server, and we would succeed just
fine. Then when we tried to run the code, it would fail miserably.
Removing the code is the correct solution.
Ryan
_______________________________________________________________________________
Ryan Bloom rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------