You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by "James Taylor (JIRA)" <ji...@apache.org> on 2016/01/04 17:00:41 UTC
[jira] [Updated] (PHOENIX-2560) PhoenixMetricsIT test failures
[ https://issues.apache.org/jira/browse/PHOENIX-2560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Taylor updated PHOENIX-2560:
----------------------------------
Attachment: PHOENIX-2560.patch
Traced the problem down to a commit that shouldn't have been there plus what looks like an unnecessary hack in UpsertCompiler.java. The commit will be done outside of this code, at the top level statement execution level after the last batch is processed. The join we do of the last batch rolls up the metrics followed by another join that rolls it up to the top level metrics. Without this commit, a commit is necessary in ConnectionQueryServices.updateData() which is the code path of the UPSERT SELECT call used to build secondary indexes.
Please review, [~samarthjain].
> PhoenixMetricsIT test failures
> ------------------------------
>
> Key: PHOENIX-2560
> URL: https://issues.apache.org/jira/browse/PHOENIX-2560
> Project: Phoenix
> Issue Type: Bug
> Reporter: James Taylor
> Attachments: PHOENIX-2560.patch
>
>
> My commit for PHOENIX-2558 seems to have broken a few metrics test. Any ideas, [~samarthjain]?
> {code}
> Running org.apache.phoenix.monitoring.PhoenixMetricsIT
> Tests run: 17, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 65.968 sec <<< FAILURE! - in org.apache.phoenix.monitoring.PhoenixMetricsIT
> testMetricsForUpsertSelectWithAutoCommit(org.apache.phoenix.monitoring.PhoenixMetricsIT) Time elapsed: 3.772 sec <<< FAILURE!
> java.lang.AssertionError: Unequal values for metric MUTATION_BYTES expected:<5600> but was:<16240>
> at org.apache.phoenix.monitoring.PhoenixMetricsIT.assertMetricsHaveSameValues(PhoenixMetricsIT.java:654)
> at org.apache.phoenix.monitoring.PhoenixMetricsIT.assertMetricsAreSame(PhoenixMetricsIT.java:643)
> at org.apache.phoenix.monitoring.PhoenixMetricsIT.testMetricsForUpsertSelectWithAutoCommit(PhoenixMetricsIT.java:462)
> testMetricsForUpsertSelectSameTable(org.apache.phoenix.monitoring.PhoenixMetricsIT) Time elapsed: 2.878 sec <<< FAILURE!
> java.lang.AssertionError: Unequal values for metric MUTATION_BYTES expected:<5600> but was:<16240>
> at org.apache.phoenix.monitoring.PhoenixMetricsIT.assertMetricsHaveSameValues(PhoenixMetricsIT.java:654)
> at org.apache.phoenix.monitoring.PhoenixMetricsIT.assertMetricsAreSame(PhoenixMetricsIT.java:643)
> at org.apache.phoenix.monitoring.PhoenixMetricsIT.testMetricsForUpsertSelectSameTable(PhoenixMetricsIT.java:615)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)