Re: [PR] Fix typed persistence stack overflow with many read only commands [pekko]

["Tomassino-ibm (via GitHub)" <gi...@apache.org>]

Tomassino-ibm commented on PR #1919:
URL: https://github.com/apache/pekko/pull/1919#issuecomment-3031825530

   Hi, I pushed some new commits: I added a feature flag to enable the fix and also ported the fix to DurableStateBehavior. I have, however, two questions.
   
   The first one is: when I added the configuration parameter to DurableStateSettings, I noticed that they are the same (I mean, also same config path) as the ones of EventSourcedSettings. Is this expected?
   
   The other one might be important, but I need help from somebody that is more familiar than me with pekko internals. The fix I added breaks the recursion by using a while loop in `onCommand` and storing recursive `onCommand` call parameters during the call to `onMessage`, which are then used when the control gets back to `onCommand`. There is, however, one function in the recursion chain, that calls another function _after_ the call leading to the recursion: `org.apache.pekko.actor.typed.Behavior$.interpret` calls `start` on the beavior returned by `onMessage`. Since it's not clear to me what `start` actually does and what "starting a behavior" means, my fear is that the recursive and non-recursive versions might do different things, at least in some edge cases. Can this be a problem?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org