[jira] Commented: (SHINDIG-116) [PATCH] More social POJOs

["Cassie Doll (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SHINDIG-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12577447#action_12577447 ] 

Cassie Doll commented on SHINDIG-116:
-------------------------------------

Thanks for the work Vincent. This almost completely flushed out our pojos, all we need now is the Enum class. 

I had to make a few modifications to this patch, so here is what to watch for in the future:

1. Make sure all lines are less than 80 cols (mostly in the test file)
2. Watch your spaces, almost everything needs a space around it (equals sign, brackets, etc)
3. A bunch of the fields you marked as a Url object were actually Strings (the Activity and Media item urls for instance) be sure to watch for those in any future changes. 
4. Removed some erroneous calls to super()

And one small thing, I moved the Type enum into the MediaItem class just to better reflect the javascript. 
Thanks again!

- Cassie

> [PATCH] More social POJOs
> -------------------------
>
>                 Key: SHINDIG-116
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-116
>             Project: Shindig
>          Issue Type: New Feature
>          Components: Gadgets Server - Java
>            Reporter: Vincent Demay
>         Attachments: social.patch.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.