You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2019/02/23 14:41:15 UTC
[Impala-ASF-CR](2.x) [DOCS] Update to the workaround for IMPALA-3316
Hello Csaba Ringhofer, Impala Public Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/12565
to review the following change.
Change subject: [DOCS] Update to the workaround for IMPALA-3316
......................................................................
[DOCS] Update to the workaround for IMPALA-3316
Both the date and time strings can be stored and converted to TIMESTAMP
Change-Id: If45da5d24dd3bc5f649d95b5bc104047420dbea1
Reviewed-on: http://gerrit.cloudera.org:8080/10800
Reviewed-by: Csaba Ringhofer <cs...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M docs/topics/impala_known_issues.xml
1 file changed, 13 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/12565/1
--
To view, visit http://gerrit.cloudera.org:8080/12565
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: If45da5d24dd3bc5f649d95b5bc104047420dbea1
Gerrit-Change-Number: 12565
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR](2.x) [DOCS] Update to the workaround for IMPALA-3316
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12565 )
Change subject: [DOCS] Update to the workaround for IMPALA-3316
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12565
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: If45da5d24dd3bc5f649d95b5bc104047420dbea1
Gerrit-Change-Number: 12565
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 23 Feb 2019 16:13:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) [DOCS] Update to the workaround for IMPALA-3316
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/12565 )
Change subject: [DOCS] Update to the workaround for IMPALA-3316
......................................................................
Patch Set 2:
Thank you very much, Tim!
--
To view, visit http://gerrit.cloudera.org:8080/12565
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: If45da5d24dd3bc5f649d95b5bc104047420dbea1
Gerrit-Change-Number: 12565
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sun, 24 Feb 2019 00:00:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) [DOCS] Update to the workaround for IMPALA-3316
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/12565 )
Change subject: [DOCS] Update to the workaround for IMPALA-3316
......................................................................
Patch Set 1:
This is a cherrypick for https://gerrit.cloudera.org/c/10800.
The conflicts is due to the absence of the part about IMPALA-6028. That part is actually not in the doc of 2.x. In the master branch, that part is also removed in a later commit: https://gerrit.cloudera.org/c/11921/. So I remove that part directly.
--
To view, visit http://gerrit.cloudera.org:8080/12565
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: If45da5d24dd3bc5f649d95b5bc104047420dbea1
Gerrit-Change-Number: 12565
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Sat, 23 Feb 2019 14:45:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) [DOCS] Update to the workaround for IMPALA-3316
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12565 )
Change subject: [DOCS] Update to the workaround for IMPALA-3316
......................................................................
Patch Set 1:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/233/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/12565
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: If45da5d24dd3bc5f649d95b5bc104047420dbea1
Gerrit-Change-Number: 12565
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 23 Feb 2019 14:41:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) [DOCS] Update to the workaround for IMPALA-3316
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12565 )
Change subject: [DOCS] Update to the workaround for IMPALA-3316
......................................................................
Patch Set 1: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/233/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/12565
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: If45da5d24dd3bc5f649d95b5bc104047420dbea1
Gerrit-Change-Number: 12565
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 23 Feb 2019 14:58:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) [DOCS] Update to the workaround for IMPALA-3316
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12565 )
Change subject: [DOCS] Update to the workaround for IMPALA-3316
......................................................................
[DOCS] Update to the workaround for IMPALA-3316
Both the date and time strings can be stored and converted to TIMESTAMP
Change-Id: If45da5d24dd3bc5f649d95b5bc104047420dbea1
Reviewed-on: http://gerrit.cloudera.org:8080/10800
Reviewed-by: Csaba Ringhofer <cs...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-on: http://gerrit.cloudera.org:8080/12565
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
---
M docs/topics/impala_known_issues.xml
1 file changed, 13 insertions(+), 4 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Tim Armstrong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/12565
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: merged
Gerrit-Change-Id: If45da5d24dd3bc5f649d95b5bc104047420dbea1
Gerrit-Change-Number: 12565
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR](2.x) [DOCS] Update to the workaround for IMPALA-3316
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/12565 )
Change subject: [DOCS] Update to the workaround for IMPALA-3316
......................................................................
Patch Set 1:
Tim, if you approve it, could you do me a favor to submit it and run cherrypick-2.x-and-test for a time? Just to save more time :)
--
To view, visit http://gerrit.cloudera.org:8080/12565
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: If45da5d24dd3bc5f649d95b5bc104047420dbea1
Gerrit-Change-Number: 12565
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 23 Feb 2019 15:00:47 +0000
Gerrit-HasComments: No