You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/07/19 01:27:38 UTC
[GitHub] [inlong] dockerzhang commented on a diff in pull request #4938: [INLONG-4937][Manager] One inlong group id can transform data across two cluster tags
dockerzhang commented on code in PR #4938:
URL: https://github.com/apache/inlong/pull/4938#discussion_r923981081
##########
inlong-manager/manager-web/src/main/java/org/apache/inlong/manager/web/controller/openapi/DataProxyController.java:
##########
@@ -82,4 +87,25 @@ public String getAllConfig(@RequestParam String clusterName, @RequestParam(requi
return clusterService.getAllConfig(clusterName, md5);
}
+ /**
+ * changeClusterTag
+ */
+ @RequestMapping(value = "/changeClusterTag", method = RequestMethod.GET)
+ @ApiOperation(value = "Change cluster tag and topic of a inlong group id.")
+ public Response<String> changeClusterTag(@RequestParam String inlongGroupId, @RequestParam String clusterTag,
+ @RequestParam String topic) {
+ String result = dataProxyConfigRepository.changeClusterTag(inlongGroupId, clusterTag, topic);
+ return Response.success(result);
+ }
+
+ /**
+ * removeSecondClusterTag
+ */
+ @RequestMapping(value = "/removeSecondClusterTag", method = RequestMethod.GET)
Review Comment:
maybe change RequestMethod.GET to RequestMethod.DELETE is better？
##########
inlong-manager/manager-web/src/main/java/org/apache/inlong/manager/web/controller/openapi/DataProxyController.java:
##########
@@ -82,4 +87,25 @@ public String getAllConfig(@RequestParam String clusterName, @RequestParam(requi
return clusterService.getAllConfig(clusterName, md5);
}
+ /**
+ * changeClusterTag
+ */
+ @RequestMapping(value = "/changeClusterTag", method = RequestMethod.GET)
+ @ApiOperation(value = "Change cluster tag and topic of a inlong group id.")
+ public Response<String> changeClusterTag(@RequestParam String inlongGroupId, @RequestParam String clusterTag,
Review Comment:
maybe change RequestMethod.GET to RequestMethod.PUT is better？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org