[GitHub] [beam] damccorm commented on pull request #23138: GA Migration Java PreCommit

[GitBox <gi...@apache.org>]

damccorm commented on PR #23138:
URL: https://github.com/apache/beam/pull/23138#issuecomment-1248204929

   > Hi @damccorm
   I am reaching out to validate the current approach for the Java Pre-commit Job. Right now we are handling the tests of the workflow in a matrix (https://github.com/apache/beam/blob/096fb6900a747aff7ae21865d578dab8157ea379/.github/workflows/job-precommit-java.yml). This allows us to have one job per test and be able to run them individually in case they fail, but this also means that for each test inside the matrix one runner/pod will be generated.
   So for example, the way we separated the JavaPrecommit workflow (tests listed inside a matrix), the total number of jobs/runners will be 40ish.
   If we add just one job for all the tests, only one runner will be created, but we lose the option of executing only the test/job that failed.
   I would like to know your thoughts on this matter. Ty
   cc: @fernando-wizeline @benWize @andoni-guzman
   
   I think my only concern here is that any build steps will have to be run for every single worker. Could we consider having 1 build job that runs common steps that build any artifacts and [persists them](https://levelup.gitconnected.com/github-actions-how-to-share-data-between-jobs-fc1547defc3e) so that later jobs just have to download the artifact and run?
   
   > We got the following reports Errorprone, Java and SpotBugs. In the GA we don’t have a straightforward process (the plugins for errorprone, java & spotbugs) since we don’t have any plugins as in Jenkins for this.
   As a proposal, we are thinking that we can leave the GA for java pre-commit and as well the Jenkins job meanwhile we continue working on adapting the job.
   
   I think leaving those out initially should be ok, and we can keep running those in Jenkins until we figure out a GitHub Actions solution to the problem
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org