You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/02/21 10:42:06 UTC

[GitHub] wolfmanfx opened a new pull request #544: Fix https://github.com/apache/cordova-ios/issues/538 now we update on…

wolfmanfx opened a new pull request #544: Fix https://github.com/apache/cordova-ios/issues/538 now we update on…
URL: https://github.com/apache/cordova-ios/pull/544
 
 
   …ly the app target
   
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   iOS
   
   
   ### Motivation and Context
   https://github.com/apache/cordova-ios/issues/538
   
   
   
   ### Description
   Now we retrieve the correct target and update only these properties without touching other targets.
   
   
   
   ### Testing
   I have tested unit tests and the creation of standard apps + the more complex targets where I have added apple watch targets (via script using apchae xcode)
   
   
   ### Checklist
   
   - [ X] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change
   - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [ x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [ ] I've updated the documentation if necessary
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org