[GitHub] spark pull request: SPARK-2636: Expose job ID in JobWaiter API

[rxin <gi...@git.apache.org>]

Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2176#discussion_r16882947
  
    --- Diff: core/src/main/scala/org/apache/spark/FutureAction.scala ---
    @@ -149,6 +149,13 @@ class SimpleFutureAction[T] private[spark](jobWaiter: JobWaiter[_], resultFunc:
           case JobFailed(e: Exception) => scala.util.Failure(e)
         }
       }
    +
    +  /**
    +   * Get the corresponding job Id for this action
    +   */
    +  def jobId(): Int = {
    --- End diff --
    
    maybe without the parenthesis, and lower case id?
    
    ```scala
    /** Get the corresponding job id for this action. */
    def jobId = jobWaiter.jobId
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org