You are viewing a plain text version of this content. The canonical link for it is here.
Posted to c-dev@axis.apache.org by Edward Slattery <ed...@googlemail.com> on 2006/01/31 21:11:05 UTC
Re: guththila re-entrance
OK, Im now on axis-c-dev. I found some difficulties in building patches, so
I have logged this and 3 other problems on JIRA with details of the changes
needed.
I tried to attach patches, but was unable to attach files - some security
issue that I need to work out.
I have two other fixes to apply yet, which are compiler warnings for
signed/unsigned etc. And one bad return value.
Question about patches- suppose I want to provide patch files for all six of
my fixes - I guess I cant build one huge patch as that doesnt help you
decide what to apply - but I also cant apply patch after patch unless you
know the exact order to apply them - whats the protocol here?
One big patch with comments showing which parts apply to which problem, or
an ordered sequence of patches?
On 30/01/06, Sanjiva Weerawarana <sa...@opensource.lk> wrote:
>
> Hi Ed,
>
> This would be a *very* useful update! Please go ahead and patch it ...
>
> BTW this discussion belongs in axis-c-dev and not here.
>
> Thanks,
>
> Sanjiva.
>
> On Thu, 2006-01-26 at 14:27 +0000, Edward Slattery wrote:
> >
> >
> > I dont know where to log this one - anyone want to tell me if its a
> > problem or I am doing something wrong?
> >
> > I am testing the Guththila parser, and have a WSDL which contains an
> > <import> of an XSD.
> >
> > I have one single guththila environment, and create a new parser for
> > each file encountered.
> >
> > Guththilla cannot handle that because guththila_event is global, and
> > the inner parse fails because of handling the wrong event
> > type (the GUTHTHILA_EMPTY_ELEMENT from the outer parse.)
> >
> > By putting the guththila_event inside the parser structure, and
> > replacing every occurence (18 in all) of guththila_event with
> > parser->guththila_event, I can successfully re-enter and parse nested
> > files.
> >
> > Would that be a useful update?
>
>
Re: guththila re-entrance
Posted by Davanum Srinivas <da...@gmail.com>.
Only ws projects :)
-- dims
On 2/2/06, John Hawkins <HA...@uk.ibm.com> wrote:
>
> Sorry !
> I was not aware that when someone has commit on one apache project they have it on them all !
>
>
>
>
> Davanum Srinivas <da...@gmail.com>
>
> 02/02/2006 18:54
>
> Please respond to
> "Apache AXIS C Developers List" <ax...@ws.apache.org>
>
>
> To Apache AXIS C Developers List <ax...@ws.apache.org>
>
>
> cc
>
>
> Subject Re: guththila re-entrance
>
>
>
>
>
>
>
>
> No,no,no.....Please don't do that :)
>
> You have commit privs. So please check them in.
>
> thanks,
> dims
>
> On 2/2/06, John Hawkins <HA...@uk.ibm.com> wrote:
> >
> > Thanks Ed !
> >
> > An ordered sequence of patches would appear to be best solution for tracking.
> > Keep 'em coming ;-)
> >
> > cheers,
> > John.
> >
> >
> >
> >
> >
> > Edward Slattery <ed...@googlemail.com>
> >
> > 31/01/2006 21:11
> >
> > Please respond to
> > "Apache AXIS C Developers List" <ax...@ws.apache.org>
> >
> >
> > To axis-c-dev@ws.apache.org
> >
> > cc
> >
> >
> > Subject Re: guththila re-entrance
> >
> >
> >
> >
> >
> >
> >
> >
> > OK, Im now on axis-c-dev. I found some difficulties in building patches, so I have logged this and 3 other problems on JIRA with details of the changes needed.
> > I tried to attach patches, but was unable to attach files - some security issue that I need to work out.
> > I have two other fixes to apply yet, which are compiler warnings for signed/unsigned etc. And one bad return value.
> > Question about patches- suppose I want to provide patch files for all six of my fixes - I guess I cant build one huge patch as that doesnt help you decide what to apply - but I also cant apply patch after patch unless you know the exact order to apply them - whats the protocol here?
> > One big patch with comments showing which parts apply to which problem, or an ordered sequence of patches?
> >
> >
> >
> > On 30/01/06, Sanjiva Weerawarana <sa...@opensource.lk> wrote:
> > Hi Ed,
> >
> > This would be a *very* useful update! Please go ahead and patch it ...
> >
> > BTW this discussion belongs in axis-c-dev and not here.
> >
> > Thanks,
> >
> > Sanjiva.
> >
> > On Thu, 2006-01-26 at 14:27 +0000, Edward Slattery wrote:
> > >
> > >
> > > I dont know where to log this one - anyone want to tell me if its a
> > > problem or I am doing something wrong?
> > >
> > > I am testing the Guththila parser, and have a WSDL which contains an
> > > <import> of an XSD.
> > >
> > > I have one single guththila environment, and create a new parser for
> > > each file encountered.
> > >
> > > Guththilla cannot handle that because guththila_event is global, and
> > > the inner parse fails because of handling the wrong event
> > > type (the GUTHTHILA_EMPTY_ELEMENT from the outer parse.)
> > >
> > > By putting the guththila_event inside the parser structure, and
> > > replacing every occurence (18 in all) of guththila_event with
> > > parser->guththila_event, I can successfully re-enter and parse nested
> > > files.
> > >
> > > Would that be a useful update?
> >
> >
> >
>
>
>
> --
> Davanum Srinivas : http://wso2.com/blogs/
>
>
--
Davanum Srinivas : http://wso2.com/blogs/
Re: guththila re-entrance
Posted by John Hawkins <HA...@uk.ibm.com>.
Sorry !
I was not aware that when someone has commit on one apache project they
have it on them all !
Davanum Srinivas <da...@gmail.com>
02/02/2006 18:54
Please respond to
"Apache AXIS C Developers List" <ax...@ws.apache.org>
To
Apache AXIS C Developers List <ax...@ws.apache.org>
cc
Subject
Re: guththila re-entrance
No,no,no.....Please don't do that :)
You have commit privs. So please check them in.
thanks,
dims
On 2/2/06, John Hawkins <HA...@uk.ibm.com> wrote:
>
> Thanks Ed !
>
> An ordered sequence of patches would appear to be best solution for
tracking.
> Keep 'em coming ;-)
>
> cheers,
> John.
>
>
>
>
>
> Edward Slattery <ed...@googlemail.com>
>
> 31/01/2006 21:11
>
> Please respond to
> "Apache AXIS C Developers List" <ax...@ws.apache.org>
>
>
> To axis-c-dev@ws.apache.org
>
> cc
>
>
> Subject Re: guththila re-entrance
>
>
>
>
>
>
>
>
> OK, Im now on axis-c-dev. I found some difficulties in building patches,
so I have logged this and 3 other problems on JIRA with details of the
changes needed.
> I tried to attach patches, but was unable to attach files - some
security issue that I need to work out.
> I have two other fixes to apply yet, which are compiler warnings for
signed/unsigned etc. And one bad return value.
> Question about patches- suppose I want to provide patch files for all
six of my fixes - I guess I cant build one huge patch as that doesnt help
you decide what to apply - but I also cant apply patch after patch unless
you know the exact order to apply them - whats the protocol here?
> One big patch with comments showing which parts apply to which problem,
or an ordered sequence of patches?
>
>
>
> On 30/01/06, Sanjiva Weerawarana <sa...@opensource.lk> wrote:
> Hi Ed,
>
> This would be a *very* useful update! Please go ahead and patch it ...
>
> BTW this discussion belongs in axis-c-dev and not here.
>
> Thanks,
>
> Sanjiva.
>
> On Thu, 2006-01-26 at 14:27 +0000, Edward Slattery wrote:
> >
> >
> > I dont know where to log this one - anyone want to tell me if its a
> > problem or I am doing something wrong?
> >
> > I am testing the Guththila parser, and have a WSDL which contains an
> > <import> of an XSD.
> >
> > I have one single guththila environment, and create a new parser for
> > each file encountered.
> >
> > Guththilla cannot handle that because guththila_event is global, and
> > the inner parse fails because of handling the wrong event
> > type (the GUTHTHILA_EMPTY_ELEMENT from the outer parse.)
> >
> > By putting the guththila_event inside the parser structure, and
> > replacing every occurence (18 in all) of guththila_event with
> > parser->guththila_event, I can successfully re-enter and parse nested
> > files.
> >
> > Would that be a useful update?
>
>
>
--
Davanum Srinivas : http://wso2.com/blogs/
Re: guththila re-entrance
Posted by Davanum Srinivas <da...@gmail.com>.
No,no,no.....Please don't do that :)
You have commit privs. So please check them in.
thanks,
dims
On 2/2/06, John Hawkins <HA...@uk.ibm.com> wrote:
>
> Thanks Ed !
>
> An ordered sequence of patches would appear to be best solution for tracking.
> Keep 'em coming ;-)
>
> cheers,
> John.
>
>
>
>
>
> Edward Slattery <ed...@googlemail.com>
>
> 31/01/2006 21:11
>
> Please respond to
> "Apache AXIS C Developers List" <ax...@ws.apache.org>
>
>
> To axis-c-dev@ws.apache.org
>
> cc
>
>
> Subject Re: guththila re-entrance
>
>
>
>
>
>
>
>
> OK, Im now on axis-c-dev. I found some difficulties in building patches, so I have logged this and 3 other problems on JIRA with details of the changes needed.
> I tried to attach patches, but was unable to attach files - some security issue that I need to work out.
> I have two other fixes to apply yet, which are compiler warnings for signed/unsigned etc. And one bad return value.
> Question about patches- suppose I want to provide patch files for all six of my fixes - I guess I cant build one huge patch as that doesnt help you decide what to apply - but I also cant apply patch after patch unless you know the exact order to apply them - whats the protocol here?
> One big patch with comments showing which parts apply to which problem, or an ordered sequence of patches?
>
>
>
> On 30/01/06, Sanjiva Weerawarana <sa...@opensource.lk> wrote:
> Hi Ed,
>
> This would be a *very* useful update! Please go ahead and patch it ...
>
> BTW this discussion belongs in axis-c-dev and not here.
>
> Thanks,
>
> Sanjiva.
>
> On Thu, 2006-01-26 at 14:27 +0000, Edward Slattery wrote:
> >
> >
> > I dont know where to log this one - anyone want to tell me if its a
> > problem or I am doing something wrong?
> >
> > I am testing the Guththila parser, and have a WSDL which contains an
> > <import> of an XSD.
> >
> > I have one single guththila environment, and create a new parser for
> > each file encountered.
> >
> > Guththilla cannot handle that because guththila_event is global, and
> > the inner parse fails because of handling the wrong event
> > type (the GUTHTHILA_EMPTY_ELEMENT from the outer parse.)
> >
> > By putting the guththila_event inside the parser structure, and
> > replacing every occurence (18 in all) of guththila_event with
> > parser->guththila_event, I can successfully re-enter and parse nested
> > files.
> >
> > Would that be a useful update?
>
>
>
--
Davanum Srinivas : http://wso2.com/blogs/
Re: guththila re-entrance
Posted by Davanum Srinivas <da...@gmail.com>.
Ed,
You have commit privs. Can u please check in the code yourself? :)
thanks,
dims
On 1/31/06, Edward Slattery <ed...@googlemail.com> wrote:
> OK, Im now on axis-c-dev. I found some difficulties in building patches, so
> I have logged this and 3 other problems on JIRA with details of the changes
> needed.
> I tried to attach patches, but was unable to attach files - some security
> issue that I need to work out.
> I have two other fixes to apply yet, which are compiler warnings for
> signed/unsigned etc. And one bad return value.
> Question about patches- suppose I want to provide patch files for all six of
> my fixes - I guess I cant build one huge patch as that doesnt help you
> decide what to apply - but I also cant apply patch after patch unless you
> know the exact order to apply them - whats the protocol here?
> One big patch with comments showing which parts apply to which problem, or
> an ordered sequence of patches?
>
>
>
> On 30/01/06, Sanjiva Weerawarana <sa...@opensource.lk> wrote:
> > Hi Ed,
> >
> > This would be a *very* useful update! Please go ahead and patch it ...
> >
> > BTW this discussion belongs in axis-c-dev and not here.
> >
> > Thanks,
> >
> > Sanjiva.
> >
> > On Thu, 2006-01-26 at 14:27 +0000, Edward Slattery wrote:
> > >
> > >
> > > I dont know where to log this one - anyone want to tell me if its a
> > > problem or I am doing something wrong?
> > >
> > > I am testing the Guththila parser, and have a WSDL which contains an
> > > <import> of an XSD.
> > >
> > > I have one single guththila environment, and create a new parser for
> > > each file encountered.
> > >
> > > Guththilla cannot handle that because guththila_event is global, and
> > > the inner parse fails because of handling the wrong event
> > > type (the GUTHTHILA_EMPTY_ELEMENT from the outer parse.)
> > >
> > > By putting the guththila_event inside the parser structure, and
> > > replacing every occurence (18 in all) of guththila_event with
> > > parser->guththila_event, I can successfully re-enter and parse nested
> > > files.
> > >
> > > Would that be a useful update?
> >
> >
>
>
--
Davanum Srinivas : http://wso2.com/blogs/
Re: guththila re-entrance
Posted by John Hawkins <HA...@uk.ibm.com>.
Thanks Ed !
An ordered sequence of patches would appear to be best solution for
tracking.
Keep 'em coming ;-)
cheers,
John.
Edward Slattery <ed...@googlemail.com>
31/01/2006 21:11
Please respond to
"Apache AXIS C Developers List" <ax...@ws.apache.org>
To
axis-c-dev@ws.apache.org
cc
Subject
Re: guththila re-entrance
OK, Im now on axis-c-dev. I found some difficulties in building patches,
so I have logged this and 3 other problems on JIRA with details of the
changes needed.
I tried to attach patches, but was unable to attach files - some security
issue that I need to work out.
I have two other fixes to apply yet, which are compiler warnings for
signed/unsigned etc. And one bad return value.
Question about patches- suppose I want to provide patch files for all six
of my fixes - I guess I cant build one huge patch as that doesnt help you
decide what to apply - but I also cant apply patch after patch unless you
know the exact order to apply them - whats the protocol here?
One big patch with comments showing which parts apply to which problem, or
an ordered sequence of patches?
On 30/01/06, Sanjiva Weerawarana <sa...@opensource.lk> wrote:
Hi Ed,
This would be a *very* useful update! Please go ahead and patch it ...
BTW this discussion belongs in axis-c-dev and not here.
Thanks,
Sanjiva.
On Thu, 2006-01-26 at 14:27 +0000, Edward Slattery wrote:
>
>
> I dont know where to log this one - anyone want to tell me if its a
> problem or I am doing something wrong?
>
> I am testing the Guththila parser, and have a WSDL which contains an
> <import> of an XSD.
>
> I have one single guththila environment, and create a new parser for
> each file encountered.
>
> Guththilla cannot handle that because guththila_event is global, and
> the inner parse fails because of handling the wrong event
> type (the GUTHTHILA_EMPTY_ELEMENT from the outer parse.)
>
> By putting the guththila_event inside the parser structure, and
> replacing every occurence (18 in all) of guththila_event with
> parser->guththila_event, I can successfully re-enter and parse nested
> files.
>
> Would that be a useful update?