You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuweni.apache.org by GitBox <gi...@apache.org> on 2021/01/10 08:54:32 UTC

[GitHub] [incubator-tuweni] atoulme opened a new pull request #191: Add sodium to hashing

atoulme opened a new pull request #191:
URL: https://github.com/apache/incubator-tuweni/pull/191


   <!-- Thanks for sending a pull request! Please check out our contribution guidelines: -->
   <!-- https://github.com/apache/incubator-tuweni/blob/master/CONTRIBUTING.md -->
   
   ## PR description
   Add sodium to a few sha256 functions that can use directly 
   
   ## Fixed Issue(s)
   Fixes #147
   <!-- Please link to fixed issue(s) here using format: fixes #<issue number> -->
   <!-- Example: "fixes #2" -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org

[GitHub] [incubator-tuweni] codecov[bot] commented on pull request #191: Add sodium to hashing

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #191:
URL: https://github.com/apache/incubator-tuweni/pull/191#issuecomment-757442257


   # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/191?src=pr&el=h1) Report
   > Merging [#191](https://codecov.io/gh/apache/incubator-tuweni/pull/191?src=pr&el=desc) (465fcca) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/2293c03b05ed867d239a47814940b122aeee553b?el=desc) (2293c03) will **decrease** coverage by `16.32%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-tuweni/pull/191/graphs/tree.svg?width=650&height=150&src=pr&token=U8STS3qOg5)](https://codecov.io/gh/apache/incubator-tuweni/pull/191?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master     #191       +/-   ##
   =============================================
   - Coverage     65.51%   49.19%   -16.33%     
   + Complexity     4169      611     -3558     
   =============================================
     Files           372      128      -244     
     Lines         19951     5895    -14056     
     Branches       2594      676     -1918     
   =============================================
   - Hits          13071     2900    -10171     
   + Misses         5421     2697     -2724     
   + Partials       1459      298     -1161     
   ```
   
   | Flag | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | integration | `49.19% <ø> (+0.06%)` | `0.00 <ø> (ø)` | |
   | unit | `?` | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/191?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../main/java/org/apache/tuweni/ethstats/TxStats.java](https://codecov.io/gh/apache/incubator-tuweni/pull/191/diff?src=pr&el=tree#diff-ZXRoc3RhdHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ldGhzdGF0cy9UeFN0YXRzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...weni/scuttlebutt/handshake/HandshakeException.java](https://codecov.io/gh/apache/incubator-tuweni/pull/191/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtaGFuZHNoYWtlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvaGFuZHNoYWtlL0hhbmRzaGFrZUV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...ebutt/handshake/SecureScuttlebuttStreamServer.java](https://codecov.io/gh/apache/incubator-tuweni/pull/191/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtaGFuZHNoYWtlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvaGFuZHNoYWtlL1NlY3VyZVNjdXR0bGVidXR0U3RyZWFtU2VydmVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `1.00% <0.00%> (-2.00%)` | |
   | [...in/kotlin/org/apache/tuweni/devp2p/eth/Messages.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/191/diff?src=pr&el=tree#diff-ZGV2cDJwLWV0aC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZGV2cDJwL2V0aC9NZXNzYWdlcy5rdA==) | `0.00% <0.00%> (-94.50%)` | `0.00% <0.00%> (ø%)` | |
   | [...kotlin/org/apache/tuweni/devp2p/v5/topic/Ticket.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/191/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvdG9waWMvVGlja2V0Lmt0) | `0.00% <0.00%> (-83.88%)` | `0.00% <0.00%> (-9.00%)` | |
   | [...lin/org/apache/tuweni/devp2p/eth/EthSubprotocol.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/191/diff?src=pr&el=tree#diff-ZGV2cDJwLWV0aC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZGV2cDJwL2V0aC9FdGhTdWJwcm90b2NvbC5rdA==) | `0.00% <0.00%> (-78.95%)` | `0.00% <0.00%> (-12.00%)` | |
   | [...ain/kotlin/org/apache/tuweni/devp2p/v5/Messages.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/191/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvTWVzc2FnZXMua3Q=) | `18.88% <0.00%> (-72.73%)` | `0.00% <0.00%> (ø%)` | |
   | [...in/org/apache/tuweni/devp2p/v5/topic/TopicTable.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/191/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvdG9waWMvVG9waWNUYWJsZS5rdA==) | `17.64% <0.00%> (-67.65%)` | `2.00% <0.00%> (-12.00%)` | |
   | [...src/main/kotlin/org/apache/tuweni/devp2p/Packet.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/191/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvUGFja2V0Lmt0) | `16.73% <0.00%> (-62.67%)` | `4.00% <0.00%> (-2.00%)` | |
   | [...p/src/main/kotlin/org/apache/tuweni/devp2p/Node.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/191/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvTm9kZS5rdA==) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | ... and [286 more](https://codecov.io/gh/apache/incubator-tuweni/pull/191/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/191?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/191?src=pr&el=footer). Last update [72681ad...465fcca](https://codecov.io/gh/apache/incubator-tuweni/pull/191?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org

[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #191: Add sodium to hashing

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #191:
URL: https://github.com/apache/incubator-tuweni/pull/191#issuecomment-757442257


   # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/191?src=pr&el=h1) Report
   > Merging [#191](https://codecov.io/gh/apache/incubator-tuweni/pull/191?src=pr&el=desc) (30f375d) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/2293c03b05ed867d239a47814940b122aeee553b?el=desc) (2293c03) will **decrease** coverage by `4.91%`.
   > The diff coverage is `22.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-tuweni/pull/191/graphs/tree.svg?width=650&height=150&src=pr&token=U8STS3qOg5)](https://codecov.io/gh/apache/incubator-tuweni/pull/191?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #191      +/-   ##
   ============================================
   - Coverage     65.51%   60.59%   -4.92%     
   + Complexity     4169     3893     -276     
   ============================================
     Files           372      350      -22     
     Lines         19951    19736     -215     
     Branches       2594     2605      +11     
   ============================================
   - Hits          13071    11960    -1111     
   - Misses         5421     6420     +999     
   + Partials       1459     1356     -103     
   ```
   
   | Flag | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | integration | `?` | `?` | |
   | unit | `60.59% <22.03%> (-0.20%)` | `0.00 <5.00> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/191?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...va/org/apache/tuweni/crypto/sodium/SHA512Hash.java](https://codecov.io/gh/apache/incubator-tuweni/pull/191/diff?src=pr&el=tree#diff-Y3J5cHRvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvY3J5cHRvL3NvZGl1bS9TSEE1MTJIYXNoLmphdmE=) | `4.34% <4.34%> (ø)` | `0.00 <0.00> (?)` | |
   | [...o/src/main/java/org/apache/tuweni/crypto/Hash.java](https://codecov.io/gh/apache/incubator-tuweni/pull/191/diff?src=pr&el=tree#diff-Y3J5cHRvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvY3J5cHRvL0hhc2guamF2YQ==) | `87.09% <84.61%> (-0.66%)` | `15.00 <5.00> (+2.00)` | :arrow_down: |
   | [.../java/org/apache/tuweni/rlpx/wire/SubProtocol.java](https://codecov.io/gh/apache/incubator-tuweni/pull/191/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...apache/tuweni/rlpx/wire/SubProtocolIdentifier.java](https://codecov.io/gh/apache/incubator-tuweni/pull/191/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbElkZW50aWZpZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [.../apache/tuweni/scuttlebutt/rpc/RPCRequestBody.java](https://codecov.io/gh/apache/incubator-tuweni/pull/191/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1JlcXVlc3RCb2R5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | [.../apache/tuweni/scuttlebutt/rpc/RPCRequestType.java](https://codecov.io/gh/apache/incubator-tuweni/pull/191/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...apache/tuweni/scuttlebutt/rpc/RPCAsyncRequest.java](https://codecov.io/gh/apache/incubator-tuweni/pull/191/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ0FzeW5jUmVxdWVzdC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | [...pache/tuweni/scuttlebutt/rpc/RPCStreamRequest.java](https://codecov.io/gh/apache/incubator-tuweni/pull/191/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1N0cmVhbVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | [.../rpc/mux/exceptions/RPCRequestFailedException.java](https://codecov.io/gh/apache/incubator-tuweni/pull/191/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL211eC9leGNlcHRpb25zL1JQQ1JlcXVlc3RGYWlsZWRFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...tt/discovery/ScuttlebuttLocalDiscoveryService.java](https://codecov.io/gh/apache/incubator-tuweni/pull/191/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtZGlzY292ZXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvZGlzY292ZXJ5L1NjdXR0bGVidXR0TG9jYWxEaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-82.54%)` | `0.00% <0.00%> (-18.00%)` | |
   | ... and [74 more](https://codecov.io/gh/apache/incubator-tuweni/pull/191/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/191?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/191?src=pr&el=footer). Last update [72681ad...30f375d](https://codecov.io/gh/apache/incubator-tuweni/pull/191?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org

[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #191: Add sodium to hashing

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #191:
URL: https://github.com/apache/incubator-tuweni/pull/191#issuecomment-757442257


   # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/191?src=pr&el=h1) Report
   > Merging [#191](https://codecov.io/gh/apache/incubator-tuweni/pull/191?src=pr&el=desc) (30f375d) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/2293c03b05ed867d239a47814940b122aeee553b?el=desc) (2293c03) will **decrease** coverage by `0.23%`.
   > The diff coverage is `22.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-tuweni/pull/191/graphs/tree.svg?width=650&height=150&src=pr&token=U8STS3qOg5)](https://codecov.io/gh/apache/incubator-tuweni/pull/191?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #191      +/-   ##
   ============================================
   - Coverage     65.51%   65.28%   -0.24%     
   - Complexity     4169     4189      +20     
   ============================================
     Files           372      375       +3     
     Lines         19951    20117     +166     
     Branches       2594     2612      +18     
   ============================================
   + Hits          13071    13133      +62     
   - Misses         5421     5511      +90     
   - Partials       1459     1473      +14     
   ```
   
   | Flag | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | integration | `49.26% <ø> (+0.13%)` | `0.00 <ø> (ø)` | |
   | unit | `60.59% <22.03%> (-0.20%)` | `0.00 <5.00> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/191?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...va/org/apache/tuweni/crypto/sodium/SHA512Hash.java](https://codecov.io/gh/apache/incubator-tuweni/pull/191/diff?src=pr&el=tree#diff-Y3J5cHRvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvY3J5cHRvL3NvZGl1bS9TSEE1MTJIYXNoLmphdmE=) | `4.34% <4.34%> (ø)` | `0.00 <0.00> (?)` | |
   | [...o/src/main/java/org/apache/tuweni/crypto/Hash.java](https://codecov.io/gh/apache/incubator-tuweni/pull/191/diff?src=pr&el=tree#diff-Y3J5cHRvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvY3J5cHRvL0hhc2guamF2YQ==) | `87.09% <84.61%> (-0.66%)` | `15.00 <5.00> (+2.00)` | :arrow_down: |
   | [...src/main/java/org/apache/tuweni/bytes/Bytes32.java](https://codecov.io/gh/apache/incubator-tuweni/pull/191/diff?src=pr&el=tree#diff-Ynl0ZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ieXRlcy9CeXRlczMyLmphdmE=) | `50.00% <0.00%> (-5.32%)` | `13.00% <0.00%> (ø%)` | |
   | [...he/tuweni/concurrent/coroutines/AsyncCompletion.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/191/diff?src=pr&el=tree#diff-Y29uY3VycmVudC1jb3JvdXRpbmVzL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9jb25jdXJyZW50L2Nvcm91dGluZXMvQXN5bmNDb21wbGV0aW9uLmt0) | `69.64% <0.00%> (-3.58%)` | `0.00% <0.00%> (ø%)` | |
   | [.../kotlin/org/apache/tuweni/kv/RedisKeyValueStore.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/191/diff?src=pr&el=tree#diff-a3Yvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvdHV3ZW5pL2t2L1JlZGlzS2V5VmFsdWVTdG9yZS5rdA==) | `70.31% <0.00%> (-1.57%)` | `6.00% <0.00%> (-1.00%)` | |
   | [...tlin/org/apache/tuweni/ethclient/EthereumClient.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/191/diff?src=pr&el=tree#diff-ZXRoLWNsaWVudC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZXRoY2xpZW50L0V0aGVyZXVtQ2xpZW50Lmt0) | `76.82% <0.00%> (-1.22%)` | `5.00% <0.00%> (ø%)` | |
   | [...otlin/org/apache/tuweni/devp2p/DiscoveryService.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/191/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRGlzY292ZXJ5U2VydmljZS5rdA==) | `48.93% <0.00%> (-1.19%)` | `0.00% <0.00%> (ø%)` | |
   | [...org/apache/tuweni/bytes/GuardedByteArrayBytes.java](https://codecov.io/gh/apache/incubator-tuweni/pull/191/diff?src=pr&el=tree#diff-Ynl0ZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ieXRlcy9HdWFyZGVkQnl0ZUFycmF5Qnl0ZXMuamF2YQ==) | `55.29% <0.00%> (ø)` | `16.00% <0.00%> (?%)` | |
   | [...g/apache/tuweni/bytes/GuardedByteArrayBytes32.java](https://codecov.io/gh/apache/incubator-tuweni/pull/191/diff?src=pr&el=tree#diff-Ynl0ZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ieXRlcy9HdWFyZGVkQnl0ZUFycmF5Qnl0ZXMzMi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | ... and [5 more](https://codecov.io/gh/apache/incubator-tuweni/pull/191/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/191?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/191?src=pr&el=footer). Last update [72681ad...30f375d](https://codecov.io/gh/apache/incubator-tuweni/pull/191?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org

[GitHub] [incubator-tuweni] atoulme merged pull request #191: Add sodium to hashing

Posted by GitBox <gi...@apache.org>.
atoulme merged pull request #191:
URL: https://github.com/apache/incubator-tuweni/pull/191


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org

[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #191: Add sodium to hashing

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #191:
URL: https://github.com/apache/incubator-tuweni/pull/191#issuecomment-757442257


   # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/191?src=pr&el=h1) Report
   > Merging [#191](https://codecov.io/gh/apache/incubator-tuweni/pull/191?src=pr&el=desc) (465fcca) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/2293c03b05ed867d239a47814940b122aeee553b?el=desc) (2293c03) will **decrease** coverage by `16.32%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-tuweni/pull/191/graphs/tree.svg?width=650&height=150&src=pr&token=U8STS3qOg5)](https://codecov.io/gh/apache/incubator-tuweni/pull/191?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master     #191       +/-   ##
   =============================================
   - Coverage     65.51%   49.19%   -16.33%     
   + Complexity     4169      611     -3558     
   =============================================
     Files           372      128      -244     
     Lines         19951     5895    -14056     
     Branches       2594      676     -1918     
   =============================================
   - Hits          13071     2900    -10171     
   + Misses         5421     2697     -2724     
   + Partials       1459      298     -1161     
   ```
   
   | Flag | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | integration | `49.19% <ø> (+0.06%)` | `0.00 <ø> (ø)` | |
   | unit | `?` | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/191?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../main/java/org/apache/tuweni/ethstats/TxStats.java](https://codecov.io/gh/apache/incubator-tuweni/pull/191/diff?src=pr&el=tree#diff-ZXRoc3RhdHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ldGhzdGF0cy9UeFN0YXRzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...weni/scuttlebutt/handshake/HandshakeException.java](https://codecov.io/gh/apache/incubator-tuweni/pull/191/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtaGFuZHNoYWtlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvaGFuZHNoYWtlL0hhbmRzaGFrZUV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...ebutt/handshake/SecureScuttlebuttStreamServer.java](https://codecov.io/gh/apache/incubator-tuweni/pull/191/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtaGFuZHNoYWtlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvaGFuZHNoYWtlL1NlY3VyZVNjdXR0bGVidXR0U3RyZWFtU2VydmVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `1.00% <0.00%> (-2.00%)` | |
   | [...in/kotlin/org/apache/tuweni/devp2p/eth/Messages.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/191/diff?src=pr&el=tree#diff-ZGV2cDJwLWV0aC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZGV2cDJwL2V0aC9NZXNzYWdlcy5rdA==) | `0.00% <0.00%> (-94.50%)` | `0.00% <0.00%> (ø%)` | |
   | [...kotlin/org/apache/tuweni/devp2p/v5/topic/Ticket.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/191/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvdG9waWMvVGlja2V0Lmt0) | `0.00% <0.00%> (-83.88%)` | `0.00% <0.00%> (-9.00%)` | |
   | [...lin/org/apache/tuweni/devp2p/eth/EthSubprotocol.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/191/diff?src=pr&el=tree#diff-ZGV2cDJwLWV0aC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZGV2cDJwL2V0aC9FdGhTdWJwcm90b2NvbC5rdA==) | `0.00% <0.00%> (-78.95%)` | `0.00% <0.00%> (-12.00%)` | |
   | [...ain/kotlin/org/apache/tuweni/devp2p/v5/Messages.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/191/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvTWVzc2FnZXMua3Q=) | `18.88% <0.00%> (-72.73%)` | `0.00% <0.00%> (ø%)` | |
   | [...in/org/apache/tuweni/devp2p/v5/topic/TopicTable.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/191/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvdG9waWMvVG9waWNUYWJsZS5rdA==) | `17.64% <0.00%> (-67.65%)` | `2.00% <0.00%> (-12.00%)` | |
   | [...src/main/kotlin/org/apache/tuweni/devp2p/Packet.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/191/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvUGFja2V0Lmt0) | `16.73% <0.00%> (-62.67%)` | `4.00% <0.00%> (-2.00%)` | |
   | [...p/src/main/kotlin/org/apache/tuweni/devp2p/Node.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/191/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvTm9kZS5rdA==) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | ... and [286 more](https://codecov.io/gh/apache/incubator-tuweni/pull/191/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/191?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/191?src=pr&el=footer). Last update [72681ad...30f375d](https://codecov.io/gh/apache/incubator-tuweni/pull/191?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org