[GitHub] [incubator-doris] HappenLee commented on a change in pull request #3820: [Spill To Disk] Analytic_Eval_Node Support Spill Disk and Del Some Unless Code

[GitBox <gi...@apache.org>]

HappenLee commented on a change in pull request #3820:
URL: https://github.com/apache/incubator-doris/pull/3820#discussion_r438215037



##########
File path: be/src/runtime/data_stream_recvr.cc
##########
@@ -360,9 +360,14 @@ DataStreamRecvr::DataStreamRecvr(
             _row_desc(row_desc),
             _is_merging(is_merging),
             _num_buffered_bytes(0),
-            _profile(profile),
             _sub_plan_query_statistics_recvr(sub_plan_query_statistics_recvr) {
-    _mem_tracker.reset(new MemTracker(-1, "DataStreamRecvr", parent_tracker));
+    _profile.reset(new RuntimeProfile(nullptr, "DataStreamRecvr"));
+    profile->add_child(_profile.get(), true, nullptr);

Review comment:
       @wutiangan Hello,  The ```profile``` is the param of the method ```DataStreamRecvr``` constructed function. ```_profile``` is the unique_ptr of the RunningProile be long to the object ```DataStreamRecvr``. 
   So they are indeed different, the suggest change may cause problem.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org