You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "mjsax (via GitHub)" <gi...@apache.org> on 2023/04/11 22:31:48 UTC

[GitHub] [kafka] mjsax commented on a diff in pull request #13497: KAFKA-14834: [2/N] Test coverage for out-of-order data in joins

mjsax commented on code in PR #13497:
URL: https://github.com/apache/kafka/pull/13497#discussion_r1163394194


##########
streams/src/test/java/org/apache/kafka/streams/integration/StreamStreamJoinIntegrationTest.java:
##########
@@ -384,7 +528,7 @@ public void testOuterRepartitioned() {
     public void testMultiInner() {
         STREAMS_CONFIG.put(StreamsConfig.APPLICATION_ID_CONFIG, appID + "-multi-inner");
 
-        final List<List<TestRecord<Long, String>>> expectedResult = Arrays.asList(
+        @SuppressWarnings("RedundantTypeArguments (explicit type arguments speedup compilation and analysis time)") final List<List<TestRecord<Long, String>>> expectedResult = Arrays.asList(

Review Comment:
   For my own education: why do we need this, and why do we add the generic types below?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org