You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by robertkowalski <gi...@git.apache.org> on 2016/01/14 02:43:42 UTC
[GitHub] couchdb-nmo pull request: use sinon instead of custom solution
GitHub user robertkowalski opened a pull request:
https://github.com/apache/couchdb-nmo/pull/21
use sinon instead of custom solution
I run into timing problems where mocha spoiled my tests and tests
where failing because of output which belongs to mocha.
additionally done:
- use mocha promise api where possible
- fix broken config.js tests (cli) which where not testing the
printed result
- fix bug in printer function which slipped through because the tests were broken
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertkowalski/couchdb-nmo sinon
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-nmo/pull/21.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #21
----
commit a663ddd52b50eecf7a7159492f6e37eb7650f9b1
Author: Robert Kowalski <ro...@kowalski.gd>
Date: 2016-01-14T01:39:20Z
use sinon instead of custom solution
I run into timing problems where mocha spoiled my tests and tests
where failing because of output which belongs to mocha.
additionally done:
- use mocha promise api where possible
- fix broken config.js tests (cli) which where not testing the
printed result
commit 430f9a7ff3a9713316ad538161ab91da822bf3c9
Author: Robert Kowalski <ro...@kowalski.gd>
Date: 2016-01-14T01:39:43Z
fix bug in printer function
fix behaviour for:
nmo config get <section> <key>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-nmo pull request: use sinon instead of custom solution
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-nmo/pull/21#issuecomment-178079086
This is awesome. Some small changes then +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-nmo pull request: use sinon instead of custom solution
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-nmo/pull/21#discussion_r51448949
--- Diff: src/config.js ---
@@ -93,6 +93,8 @@ export function handleResult (data, key) {
data = {[key]: data};
}
+ console.log(data);
--- End diff --
Debug
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-nmo pull request: use sinon instead of custom solution
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-nmo/pull/21#discussion_r51449068
--- Diff: test/cluster.js ---
@@ -4,16 +4,20 @@ import nock from 'nock';
import * as cluster from '../src/cluster.js';
import nmo from '../src/nmo.js';
import {createConfigFile} from './common.js';
-import { consoleMock } from './helpers';
+import sinon from 'sinon';
const nmoconf = {nmoconf: __dirname + '/fixtures/randomini'};
+function restore (f) {
--- End diff --
Could we make this function standard somewhere like we have it in Fauxton?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---