You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/03/18 10:03:14 UTC

[GitHub] [incubator-tvm] kazum opened a new pull request #5090: [CODEGEN][OPENCL] Explicitly cast min/max operands

kazum opened a new pull request #5090: [CODEGEN][OPENCL] Explicitly cast min/max operands
URL: https://github.com/apache/incubator-tvm/pull/5090
 
 
   OpenCL codegen needs explicit casts to min/max operands to avoid ambiguous call errors.
   This will fix the reported bug in https://discuss.tvm.ai/t/relay-opencl-quantization-error/5963
   
   #2821 looks no longer necessary, so this PR also reverts it.
   
   @lixiaoquan @tqchen please help to review.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] tqchen merged pull request #5090: [CODEGEN][OPENCL] Explicitly cast min/max operands

Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #5090: [CODEGEN][OPENCL] Explicitly cast min/max operands
URL: https://github.com/apache/incubator-tvm/pull/5090
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] tqchen commented on issue #5090: [CODEGEN][OPENCL] Explicitly cast min/max operands

Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #5090: [CODEGEN][OPENCL] Explicitly cast min/max operands
URL: https://github.com/apache/incubator-tvm/pull/5090#issuecomment-600718969
 
 
   Thanks @kazum !

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services