[jira] [Commented] (YARN-2315) Should use setCurrentCapacity instead of setCapacity to configure used resource capacity for FairScheduler.

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-2315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14209346#comment-14209346 ] 

Hadoop QA commented on YARN-2315:
---------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12681248/YARN-2315.003.patch
  against trunk revision e073b61.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-YARN-Build/5836//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5836//console

This message is automatically generated.

> Should use setCurrentCapacity instead of setCapacity to configure used resource capacity for FairScheduler.
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-2315
>                 URL: https://issues.apache.org/jira/browse/YARN-2315
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: zhihai xu
>            Assignee: zhihai xu
>         Attachments: YARN-2315.001.patch, YARN-2315.002.patch, YARN-2315.003.patch, YARN-2315.patch
>
>
> Should use setCurrentCapacity instead of setCapacity to configure used resource capacity for FairScheduler.
> In function getQueueInfo of FSQueue.java, we call setCapacity twice with different parameters so the first call is overrode by the second call. 
>     queueInfo.setCapacity((float) getFairShare().getMemory() /
>         scheduler.getClusterResource().getMemory());
>     queueInfo.setCapacity((float) getResourceUsage().getMemory() /
>         scheduler.getClusterResource().getMemory());
> We should change the second setCapacity call to setCurrentCapacity to configure the current used capacity.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)