You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by michellephung <gi...@git.apache.org> on 2014/11/25 08:11:31 UTC
[GitHub] couchdb-fauxton pull request: Add nightwatch tests to work with Tr...
GitHub user michellephung opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/168
Add nightwatch tests to work with Travis and Saucelabs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/michellephung/couchdb-fauxton 2369a-Adding-Travis-tests-to-nightwatch
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/168.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #168
----
commit 0463ed9087e6e6ab10d78c313e84bd4f63adcabf
Author: Michelle Phung <mi...@gmail.com>
Date: 2014-11-17T21:49:24Z
Add nightwatch tests to work with Travis and Saucelabs
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add nightwatch tests to work with Tr...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/168#issuecomment-64718276
i will push it to the apache github via the mirror to try to avoid the stripping of the sauce credentials, see http://docs.travis-ci.com/user/pull-requests/#Security-Restrictions-when-testing-Pull-Requests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add nightwatch tests to work with Tr...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/168#issuecomment-65708435
ah, regarding the rebase, nevermind, i'll just pick it over :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add nightwatch tests to work with Tr...
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/168#issuecomment-65288166
Okie dokies,
The tests passes with the new rebased code (so we know it works ... yay).
https://travis-ci.org/michellephung/couchdb-fauxton/builds/42762496
However, it that was with security keys for my fork.
I've updated the keys, so as of commit 0e318cd, the security keys are set to apache/couchdb-fauxton.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add nightwatch tests to work with Tr...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/168#issuecomment-64327890
There seems to be an error on travis:
```
Failed — The Travis CI build failed · Details
```
```
Error processing the server response:
Sauce Labs Authentication Error.
You used username '${SAUCE_USERNAME}' and access key '${SAUCE_ACCESS_KEY}' to authenticate, which are not valid Sauce Labs credentials.
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add nightwatch tests to work with Tr...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/168#issuecomment-65708193
can you rebase it as the branch contains conflicts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add nightwatch tests to work with Tr...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/168#issuecomment-65043099
i see that there are two secure variables added - which one is the right one?
can you also rebase the branch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add nightwatch tests to work with Tr...
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/168#issuecomment-64320597
+1 looks great. Thanks @michellephung
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add nightwatch tests to work with Tr...
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/168#issuecomment-65707046
this should work
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add nightwatch tests to work with Tr...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/168#issuecomment-65873342
cherry-picked as 781b6aaecedca09c09d5ef7ef251e79e598bb461
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add nightwatch tests to work with Tr...
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/168#issuecomment-65907225
its working! sort of...
https://travis-ci.org/apache/couchdb-fauxton/builds/43155474
here's the failing test from saucelabs:
https://saucelabs.com/tests/cfd8a012db3245c887e22f842b6dd7ca
Not sure what is going on with fauxton there. Haven't seen that behavior before.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add nightwatch tests to work with Tr...
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/168#issuecomment-65143001
The first security variable is the user name, the second security variable is the password.
I've rebased, and the new Nightwatch changes should be in here.
Travis is down right now so even if we merge , we can't see if the the PR will pass.
I would like to switch the credentials back with my fork, to see if the tests pass with all of the new rebased changes. Then, if they pass we can switch back to the apache/couchdb credentials, and try for our quick-win.
Travis is down, so I cannot generate new security keys as of yet.
Blah on Mondays!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add nightwatch tests to work with Tr...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/168#issuecomment-65707697
can you please provide a bit of context why this fixes the issue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add nightwatch tests to work with Tr...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/168#issuecomment-65290055
let's see! 3b3151ba09b09b03b73de1876bfb1f8cee0e9322
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add nightwatch tests to work with Tr...
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/168#issuecomment-65866511
hey,
fb00951 has coucdb-fauxton credentials.
I've tested it on my fork (with the credentials for my fork), and all the tests were passing, so this should work (in theory :).
I've added some pauses in a couple of places, to get the tests working better with the vm on saucelabs. Should solve our issues with not being able to find the login link when starting up.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add nightwatch tests to work with Tr...
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/168
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add nightwatch tests to work with Tr...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/168#issuecomment-65707931
http://thumbpress.com/wp-content/uploads/2013/05/I-Have-No-Idea-What-Im-Doing-3.jpg
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add nightwatch tests to work with Tr...
Posted by michellephung <gi...@git.apache.org>.
GitHub user michellephung reopened a pull request:
https://github.com/apache/couchdb-fauxton/pull/168
Add nightwatch tests to work with Travis and Saucelabs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/michellephung/couchdb-fauxton 2369a-Adding-Travis-tests-to-nightwatch
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/168.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #168
----
commit 0463ed9087e6e6ab10d78c313e84bd4f63adcabf
Author: Michelle Phung <mi...@gmail.com>
Date: 2014-11-17T21:49:24Z
Add nightwatch tests to work with Travis and Saucelabs
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add nightwatch tests to work with Tr...
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/168#issuecomment-65713505
ahh! i just rebased....
Some context:
Our travis tests are connecting with SauceLabs using SauceConnect (which is an improvement),
however when the tests go to login to Fauxton, the username and password being passed is
> username : Fauxton
password : testerpass
instead of
> username : tester
password: testerpass
so our saucelabs tests are not making it past the login screen. [View test](https://saucelabs.com/tests/f2d3d6ce14b849e9b27814d2915f88fc)
On the left-hand side of the saucelabs test, you can scroll to view what the browser is doing at each second. At 9 seconds and 10 seconds, we see that value being passed are 'Fauxton' and 'testerpass'.
In [nightwatch.json.underscore](https://github.com/apache/couchdb-fauxton/blob/master/test/nightwatch_tests/nightwatch.json.underscore#L25), the default `username`/`password` variables are being correct assigned 'tester' and 'testerpass', but then soon gets overwritten by our 'saucelabs' object, which has a key named `username`, as well.
The tests use the most recent assignment of `username`, which is what is being passed in our `${SAUCE_USERNAME}`.
In this fix (19e753d) I've done two things:
1. added `curl -X PUT $HOST/_config/admins/Fauxton -d '"testerpass"'`, in the .travis.yml file, which creates an admin with username `Fauxton`, and password `testerpass`
2. I added more wait time to the loginToGUI.js file, since the browser in saucelabs takes longer to find the login link initially.
> username : tester
password: testerpass
so our saucelabs tests are not making it past the login screen.
On the left-hand side of the saucelabs test, you can scroll to view what the browser is doing at each second. At 9 seconds and 10 seconds, we see that value being passed are 'Fauxton' and 'testerpass'.
In https://github.com/apache/couchdb-fauxton/blob/master/test/nightwatch_tests/nightwatch.json.underscore#L25
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add nightwatch tests to work with Tr...
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/168
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---