You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/02/23 00:05:47 UTC
[GitHub] [druid] techdocsmith commented on a change in pull request #10886: Remove stale 'namespace' config for JDBC lookups from doc
techdocsmith commented on a change in pull request #10886:
URL: https://github.com/apache/druid/pull/10886#discussion_r580679820
##########
File path: docs/development/extensions-core/lookups-cached-global.md
##########
@@ -377,7 +375,8 @@ The JDBC lookups will poll a database to populate its local cache. If the `tsCol
> If using JDBC, you will need to add your database's client JAR files to the extension's directory.
> For Postgres, the connector JAR is already included.
> For MySQL, you can get it from https://dev.mysql.com/downloads/connector/j/.
-> Copy or symlink the downloaded file to `extensions/druid-lookups-cached-global` under the distribution root directory.
+> The connector JAR should locate in the classpath of Druid's main class loader.
Review comment:
```suggestion
> The connector JAR should reside in the classpath of Druid's main class loader.
```
reside or "be located?"
##########
File path: docs/development/extensions-core/lookups-cached-global.md
##########
@@ -377,7 +375,8 @@ The JDBC lookups will poll a database to populate its local cache. If the `tsCol
> If using JDBC, you will need to add your database's client JAR files to the extension's directory.
> For Postgres, the connector JAR is already included.
> For MySQL, you can get it from https://dev.mysql.com/downloads/connector/j/.
-> Copy or symlink the downloaded file to `extensions/druid-lookups-cached-global` under the distribution root directory.
+> The connector JAR should locate in the classpath of Druid's main class loader.
+> An easy way to add it in the classpath is copying or symlinking the downloaded file to `lib/` under the distribution root directory.
Review comment:
```suggestion
> To add the connector JAR to the classpath, you can copy the downloaded file to `lib/` under the distribution root directory. Alternatively, create a symbolic link to the connector in the `lib` directory.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org