[jira] [Commented] (CLOUDSTACK-10081) CloudUtils getDevInfo function only checks for KVM bridgePort and not OVS

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-10081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16224817#comment-16224817 ] 

ASF GitHub Bot commented on CLOUDSTACK-10081:
---------------------------------------------

fmaximus closed pull request #2268: CLOUDSTACK-10081: getDevInfo now returns correct value
URL: https://github.com/apache/cloudstack/pull/2268
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/python/lib/cloudutils/networkConfig.py b/python/lib/cloudutils/networkConfig.py
index 41ef9d93ed2..b3ae26951ba 100644
--- a/python/lib/cloudutils/networkConfig.py
+++ b/python/lib/cloudutils/networkConfig.py
@@ -154,7 +154,7 @@ def getDevInfo(dev):
 
         if networkConfig.isBridgePort(dev):
             type = "brport"
-        elif networkConfig.isBridge(dev):
+        elif networkConfig.isBridge(dev) or networkConfig.isOvsBridge(dev):
             type = "bridge"
         else:
             type = "dev"


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> CloudUtils getDevInfo function only checks for KVM bridgePort and not OVS
> -------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-10081
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10081
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: cloudstack-agent
>    Affects Versions: 4.11.0.0
>            Reporter: Sigert Goeminne
>            Assignee: Sigert Goeminne
>
> CloudUtils getDevInfo function only checks for KVM bridgePort and not OVS. In case you provide an ovsbridge, getDevInfo(dev) will say it's a device instead of a bridge.
> h2. Scenario
> h3. Expected behaviour
> *Given* a KVM Host with openvswitch networking
> *and* kvmnetworklabel of the guest traffic type specifying the name of an existing OVS bridge.
> *When* cloudstack-setup-agent is run on the host
> *Then* the existing openvswitch bridge is used.
> h3. Actual (incorrect) behaviour
> A new bridge cloudbr0 is created in openvswitch.
> and the networking scripts define the new bridge as OVS_BRIDGE in the ifcfg of the existing bridge.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)