You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/09/23 03:10:27 UTC
[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4629: Put
order-by expressions in front of selection expreesions in selection
DataSchema
codecov-io edited a comment on issue #4629: Put order-by expressions in front of selection expreesions in selection DataSchema
URL: https://github.com/apache/incubator-pinot/pull/4629#issuecomment-533946578
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4629?src=pr&el=h1) Report
> Merging [#4629](https://codecov.io/gh/apache/incubator-pinot/pull/4629?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/eda4176dbe3fdcc61744ab8e0ed3cd1246542c8f?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `92.81%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/4629?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4629 +/- ##
============================================
+ Coverage 64.47% 64.48% +0.01%
Complexity 32 32
============================================
Files 1072 1073 +1
Lines 55702 55662 -40
Branches 8131 8114 -17
============================================
- Hits 35913 35896 -17
+ Misses 17131 17124 -7
+ Partials 2658 2642 -16
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4629?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...not/core/operator/transform/TransformOperator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4629/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vVHJhbnNmb3JtT3BlcmF0b3IuamF2YQ==) | `94.44% <100%> (-0.8%)` | `0 <0> (ø)` | |
| [...pql/parsers/PinotQuery2BrokerRequestConverter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4629/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wcWwvcGFyc2Vycy9QaW5vdFF1ZXJ5MkJyb2tlclJlcXVlc3RDb252ZXJ0ZXIuamF2YQ==) | `88.26% <100%> (-0.12%)` | `0 <0> (ø)` | |
| [...e/pinot/core/common/datatable/DataTableImplV2.java](https://codecov.io/gh/apache/incubator-pinot/pull/4629/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9jb21tb24vZGF0YXRhYmxlL0RhdGFUYWJsZUltcGxWMi5qYXZh) | `89.41% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...java/org/apache/pinot/common/utils/DataSchema.java](https://codecov.io/gh/apache/incubator-pinot/pull/4629/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvRGF0YVNjaGVtYS5qYXZh) | `84.21% <100%> (+0.33%)` | `0 <0> (ø)` | :arrow_down: |
| [.../org/apache/pinot/pql/parsers/Pql2AstListener.java](https://codecov.io/gh/apache/incubator-pinot/pull/4629/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wcWwvcGFyc2Vycy9QcWwyQXN0TGlzdGVuZXIuamF2YQ==) | `89.3% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../org/apache/pinot/core/plan/TransformPlanNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/4629/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9wbGFuL1RyYW5zZm9ybVBsYW5Ob2RlLmphdmE=) | `86.95% <100%> (-0.8%)` | `0 <0> (ø)` | |
| [...ot/core/operator/query/EmptySelectionOperator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4629/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9xdWVyeS9FbXB0eVNlbGVjdGlvbk9wZXJhdG9yLmphdmE=) | `94.44% <100%> (+5.55%)` | `0 <0> (ø)` | :arrow_down: |
| [.../core/startree/plan/StarTreeTransformPlanNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/4629/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zdGFydHJlZS9wbGFuL1N0YXJUcmVlVHJhbnNmb3JtUGxhbk5vZGUuamF2YQ==) | `75% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../org/apache/pinot/core/plan/SelectionPlanNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/4629/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9wbGFuL1NlbGVjdGlvblBsYW5Ob2RlLmphdmE=) | `52.17% <77.77%> (+4.34%)` | `0 <0> (ø)` | :arrow_down: |
| [...core/operator/filter/ExpressionFilterOperator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4629/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9maWx0ZXIvRXhwcmVzc2lvbkZpbHRlck9wZXJhdG9yLmphdmE=) | `71.71% <83.33%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| ... and [41 more](https://codecov.io/gh/apache/incubator-pinot/pull/4629/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4629?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4629?src=pr&el=footer). Last update [eda4176...c93213c](https://codecov.io/gh/apache/incubator-pinot/pull/4629?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org