You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/09 08:42:01 UTC

[GitHub] [flink] carp84 edited a comment on pull request #13393: [FLINK-19238] [RocksDB] Sanity check for arena block size

carp84 edited a comment on pull request #13393:
URL: https://github.com/apache/flink/pull/13393#issuecomment-706052335


   **Sidenote:**
   Checking the latest RocksDB source codes ([write_buffer_manager.cc](https://github.com/facebook/rocksdb/blob/master/memtable/write_buffer_manager.cc#L54), [write_buffer_manager.h](https://github.com/facebook/rocksdb/blob/master/include/rocksdb/write_buffer_manager.h#L51) and [column_family.cc](https://github.com/facebook/rocksdb/blob/master/db/column_family.cc#L215)) we could make sure the calculations stay the same as our current frocksdb version. However, this sanity check is still implementation bound and we need to watch it when upgrading the base version of frocksdb.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org