You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chi Zhang <ch...@gmail.com> on 2015/09/29 00:50:26 UTC
Review Request 38828: docker: containerizer: fixed double-closing of
STDIN in error handling.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38828/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Bugs: mesos-3519
https://issues.apache.org/jira/browse/mesos-3519
Repository: mesos
Description
-------
The slave will destroy executors that are not launched successfully, which will
close all open file descriptors, thus the extra close is not needed.
Diffs
-----
src/slave/containerizer/docker.cpp efa37266368ee12fea9134b35ebc5047a2820f94
Diff: https://reviews.apache.org/r/38828/diff/
Testing
-------
make check
Thanks,
Chi Zhang
Re: Review Request 38828: docker: containerizer: fixed double-closing
of STDIN in error handling.
Posted by Chi Zhang <ch...@gmail.com>.
> On Sept. 29, 2015, 12:31 a.m., Ben Mahler wrote:
> > src/slave/containerizer/docker.cpp, lines 926-928
> > <https://reviews.apache.org/r/38828/diff/1/?file=1086194#file1086194line926>
> >
> > I believe these were in place to terminate the subprocess, so perhaps a killtree with SIGTERM would be more appropriate to replace these with.. thoughts? Perhaps reach out to tim chen for this code.
>
> Chi Zhang wrote:
> Yeah, I checked the mesos containerizer code, which in case just returns a failure and waits for the slave to issue destroy when it gets the failure, but I will pull Tim in.
Hi Tim, could you take a look at this patch please?
- Chi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38828/#review100908
-----------------------------------------------------------
On Sept. 29, 2015, 12:50 a.m., Chi Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38828/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2015, 12:50 a.m.)
>
>
> Review request for mesos, Ben Mahler and Timothy Chen.
>
>
> Bugs: mesos-3519
> https://issues.apache.org/jira/browse/mesos-3519
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The slave will destroy executors that are not launched successfully, which will
> close all open file descriptors, thus the extra close is not needed.
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp efa37266368ee12fea9134b35ebc5047a2820f94
>
> Diff: https://reviews.apache.org/r/38828/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chi Zhang
>
>
Re: Review Request 38828: docker: containerizer: fixed double-closing
of STDIN in error handling.
Posted by Chi Zhang <ch...@gmail.com>.
> On Sept. 29, 2015, 12:31 a.m., Ben Mahler wrote:
> > src/slave/containerizer/docker.cpp, lines 926-928
> > <https://reviews.apache.org/r/38828/diff/1/?file=1086194#file1086194line926>
> >
> > I believe these were in place to terminate the subprocess, so perhaps a killtree with SIGTERM would be more appropriate to replace these with.. thoughts? Perhaps reach out to tim chen for this code.
Yeah, I checked the mesos containerizer code, which in case just returns a failure and waits for the slave to issue destroy when it gets the failure, but I will pull Tim in.
- Chi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38828/#review100908
-----------------------------------------------------------
On Sept. 28, 2015, 10:50 p.m., Chi Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38828/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2015, 10:50 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: mesos-3519
> https://issues.apache.org/jira/browse/mesos-3519
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The slave will destroy executors that are not launched successfully, which will
> close all open file descriptors, thus the extra close is not needed.
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp efa37266368ee12fea9134b35ebc5047a2820f94
>
> Diff: https://reviews.apache.org/r/38828/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chi Zhang
>
>
Re: Review Request 38828: docker: containerizer: fixed double-closing
of STDIN in error handling.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38828/#review100908
-----------------------------------------------------------
src/slave/containerizer/docker.cpp
<https://reviews.apache.org/r/38828/#comment158167>
I believe these were in place to terminate the subprocess, so perhaps a killtree with SIGTERM would be more appropriate to replace these with.. thoughts? Perhaps reach out to tim chen for this code.
- Ben Mahler
On Sept. 28, 2015, 10:50 p.m., Chi Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38828/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2015, 10:50 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: mesos-3519
> https://issues.apache.org/jira/browse/mesos-3519
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The slave will destroy executors that are not launched successfully, which will
> close all open file descriptors, thus the extra close is not needed.
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp efa37266368ee12fea9134b35ebc5047a2820f94
>
> Diff: https://reviews.apache.org/r/38828/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chi Zhang
>
>