You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2013/01/28 02:50:52 UTC

[Bug 121681] New: Wrong sorting of values in Calc

https://issues.apache.org/ooo/show_bug.cgi?id=121681

            Bug ID: 121681
        Issue Type: DEFECT
           Summary: Wrong sorting of values in Calc
    Classification: Application
           Product: spreadsheet
           Version: AOO400-dev
          Hardware: All
                OS: All
            Status: CONFIRMED
          Severity: normal
          Priority: P3
         Component: code
          Assignee: issues@openoffice.apache.org
          Reporter: pfg@apache.org
                CC: issues@openoffice.apache.org

Created attachment 80178
  --> https://issues.apache.org/ooo/attachment.cgi?id=80178&action=edit
File showing the sort error

A SUSE linux user reported a problem in OOo 3.2:

"In the attachment you can see a XY-diagram sorted by x-values which shows a
wrong stair. The whole diagram should look like stairs but oo.org uses the
y-value of the two x-value = 6 points wrong.
The two points with the x-value = 6 have the y-values 0.6333 and 0.7666. If you
click on these two points you can see that the point with y=0.7666 is UNDER the
point with y=0.6333"

I am attaching the document for reference.

The fix is very easy and non-copyrightable:

In file chart2/source/view/main/VDataSeries.cxx

Change the occurance of std::sort (line 312) for std_stable::sort.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 121681] Wrong sorting of values in Calc

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121681

brinzing <ol...@gmx.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |oliver.brinzing@gmx.de

--- Comment #2 from brinzing <ol...@gmx.de> ---
.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 121681] Wrong sorting of values in Calc

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121681

Pedro Giffuni <pf...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Pedro Giffuni <pf...@apache.org> ---
Seems to work.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 121681] Wrong sorting of values in Calc

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121681

Pedro Giffuni <pf...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hripat1989@gmail.com

--- Comment #6 from Pedro Giffuni <pf...@apache.org> ---
For reference hrishit submitted the same fix here:

https://issues.apache.org/ooo/attachment.cgi?id=80197&action=diff#main/chart2/source/view/main/VDataSeries.cxx_sec1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 121681] Wrong sorting of values in Calc

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121681

--- Comment #4 from SVN Robot <sv...@dev.null.org> ---
"pfg" committed SVN revision 1441196 into trunk:
i121681 - Wrong sorting of values in Calc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 121681] Wrong sorting of values in Calc

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121681

--- Comment #3 from Pedro Giffuni <pf...@apache.org> ---
(In reply to comment #1)
> (In reply to comment #0)
> 
> ...
> > 
> > The fix is very easy and non-copyrightable:
> > 
> > In file chart2/source/view/main/VDataSeries.cxx
> > 
> > Change the occurance of std::sort (line 312) for std_stable::sort.
> 
> I meant std::stable_sort .

I forgot to mention the fix is based on the comments by Kohei Yoshida.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 121681] Wrong sorting of values in Calc

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121681

Pedro Giffuni <pf...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Latest|---                         |AOO 3.4.1
    Confirmation on|                            |
            Version|AOO400-dev                  |AOO 3.4.1
           See Also|                            |https://bugzilla.novell.com
                   |                            |/show_bug.cgi?id=590020
         Difficulty|---                         |easy
   Target Milestone|---                         |AOO 4.0

--- Comment #1 from Pedro Giffuni <pf...@apache.org> ---
(In reply to comment #0)

...
> 
> The fix is very easy and non-copyrightable:
> 
> In file chart2/source/view/main/VDataSeries.cxx
> 
> Change the occurance of std::sort (line 312) for std_stable::sort.

I meant std::stable_sort .

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.