You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/03/31 12:13:46 UTC
[GitHub] [cloudstack] Pearl1594 opened a new pull request #6187: api: Prevent modifying acl rules order for default ACLs
Pearl1594 opened a new pull request #6187:
URL: https://github.com/apache/cloudstack/pull/6187
### Description
This PR fixes the NullPointerException seen when trying to move the rules of a default ACL
```
2022-03-31 06:59:15,323 ERROR [c.c.a.ApiAsyncJobDispatcher] (API-Job-Executor-42:ctx-d9a17d05 job-53) (logid:47b12a5e) Unexpected exception while executing org.apache.cloudstack.api.command.user.network.MoveNetworkAclItemCmd
java.lang.NullPointerException
at com.cloud.user.AccountManagerImpl.checkAccess(AccountManagerImpl.java:579)
at com.cloud.user.AccountManagerImpl.checkAccess(AccountManagerImpl.java:567)
at jdk.internal.reflect.GeneratedMethodAccessor309.invoke(Unknown Source)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:344)
at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:198)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:97)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:215)
at com.sun.proxy.$Proxy130.checkAccess(Unknown Source)
at com.cloud.network.vpc.NetworkACLServiceImpl.validateMoveAclRulesData(NetworkACLServiceImpl.java:1149)
```
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [X] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6187: api: Prevent modifying acl rules order for default ACLs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6187:
URL: https://github.com/apache/cloudstack/pull/6187#issuecomment-1084504589
@Pearl1594 a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #6187: api: Prevent modifying acl rules order for default ACLs
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #6187:
URL: https://github.com/apache/cloudstack/pull/6187#issuecomment-1084503624
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6187: api: Prevent modifying acl rules order for default ACLs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6187:
URL: https://github.com/apache/cloudstack/pull/6187#issuecomment-1084563501
@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6187: api: Prevent modifying acl rules order for default ACLs
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #6187:
URL: https://github.com/apache/cloudstack/pull/6187#issuecomment-1084561904
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6187: api: Prevent modifying acl rules order for default ACLs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6187:
URL: https://github.com/apache/cloudstack/pull/6187#issuecomment-1084556192
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3040
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org